From 819d9cca1ac3aaca86c9c135887411670435f5a1 Mon Sep 17 00:00:00 2001 From: Luis Cordova Date: Wed, 19 Mar 2014 05:57:10 -0700 Subject: [PATCH 1/2] added addSubscriber method because guzzle plugins are subscribers and not just listeners --- lib/Github/HttpClient/HttpClient.php | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lib/Github/HttpClient/HttpClient.php b/lib/Github/HttpClient/HttpClient.php index 268c1396f56..514b08262f9 100644 --- a/lib/Github/HttpClient/HttpClient.php +++ b/lib/Github/HttpClient/HttpClient.php @@ -82,6 +82,11 @@ public function addListener($eventName, $listener) $this->client->getEventDispatcher()->addListener($eventName, $listener); } + public function addSubscriber($subscriber) + { + $this->client->addSubscriber($subscriber); + } + /** * {@inheritDoc} */ From 1bb5ba7f1ed4846efdbeb961d83709b325a41032 Mon Sep 17 00:00:00 2001 From: Luis Cordova Date: Wed, 19 Mar 2014 07:26:52 -0700 Subject: [PATCH 2/2] add typehint as per @stof's suggestion --- lib/Github/HttpClient/HttpClient.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/Github/HttpClient/HttpClient.php b/lib/Github/HttpClient/HttpClient.php index 514b08262f9..59b3cce759e 100644 --- a/lib/Github/HttpClient/HttpClient.php +++ b/lib/Github/HttpClient/HttpClient.php @@ -11,6 +11,7 @@ use Github\Exception\RuntimeException; use Github\HttpClient\Listener\AuthListener; use Github\HttpClient\Listener\ErrorListener; +use Symfony\Component\EventDispatcher\EventSubscriberInterface; /** * Performs requests on GitHub API. API documentation should be self-explanatory. @@ -82,7 +83,7 @@ public function addListener($eventName, $listener) $this->client->getEventDispatcher()->addListener($eventName, $listener); } - public function addSubscriber($subscriber) + public function addSubscriber(EventSubscriberInterface $subscriber) { $this->client->addSubscriber($subscriber); }