Add typings to the mergeUpstream method

DAGpro · DAGpro · commit d5d9aff69d85 · 2022-10-24T15:20:40.000+03:00
diff --git a/lib/Github/Api/Repo.php b/lib/Github/Api/Repo.php
@@ -540,13 +540,9 @@ public function branches($username, $repository, $branch = null, array $paramete
      *
      * @link https://docs.github.com/en/rest/branches/branches#sync-a-fork-branch-with-the-upstream-repository
      *
-     * @param string      $username
-     * @param string      $repository
-     * @param string|null $branchName
-     *
      * @return array|string
      */
-    public function mergeUpstream($username, $repository, $branchName)
+    public function mergeUpstream(string $username, string $repository, string $branchName)
     {
         return $this->post(
             '/repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/merge-upstream',

Original file line number	Diff line number	Diff line change
`@@ -540,13 +540,9 @@ public function branches($username, $repository, $branch = null, array $paramete`
`540`	`540`	`*`
`541`	`541`	`* @link https://docs.github.com/en/rest/branches/branches#sync-a-fork-branch-with-the-upstream-repository`
`542`	`542`	`*`
`543`		`- * @param string $username`
`544`		`- * @param string $repository`
`545`		`- * @param string\|null $branchName`
`546`		`- *`
`547`	`543`	`* @return array\|string`
`548`	`544`	`*/`
`549`		`- public function mergeUpstream($username, $repository, $branchName)`
	`545`	`+ public function mergeUpstream(string $username, string $repository, string $branchName)`
`550`	`546`	`{`
`551`	`547`	`return $this->post(`
`552`	`548`	`'/repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/merge-upstream',`