Skip to content

Commit b36d661

Browse files
authored
Merge pull request #640 from morozov/int-id
Documented all $id parameters in API classes as int
2 parents 13003af + 116322f commit b36d661

File tree

5 files changed

+17
-17
lines changed

5 files changed

+17
-17
lines changed

lib/Github/Api/CurrentUser/Notifications.php

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,8 @@ public function markAsReadInRepository($username, $repository, array $params = a
7575
*
7676
* @link http://developer.github.com/v3/activity/notifications/#mark-a-thread-as-read
7777
*
78-
* @param string $id the notification number
79-
* @param array $params
78+
* @param int $id the notification number
79+
* @param array $params
8080
*
8181
* @return array
8282
*/
@@ -90,7 +90,7 @@ public function markAsRead($id, array $params)
9090
*
9191
* @link http://developer.github.com/v3/activity/notifications/#view-a-single-thread
9292
*
93-
* @param string $id the notification number
93+
* @param int $id the notification number
9494
*
9595
* @return array
9696
*/
@@ -104,7 +104,7 @@ public function show($id)
104104
*
105105
* @link http://developer.github.com/v3/activity/notifications/#get-a-thread-subscription
106106
*
107-
* @param string $id the notification number
107+
* @param int $id the notification number
108108
*
109109
* @return array
110110
*/
@@ -118,8 +118,8 @@ public function showSubscription($id)
118118
*
119119
* @link http://developer.github.com/v3/activity/notifications/#set-a-thread-subscription
120120
*
121-
* @param string $id the notification number
122-
* @param array $params
121+
* @param int $id the notification number
122+
* @param array $params
123123
*
124124
* @return array
125125
*/
@@ -133,7 +133,7 @@ public function createSubscription($id, array $params)
133133
*
134134
* @link http://developer.github.com/v3/activity/notifications/#delete-a-thread-subscription
135135
*
136-
* @param string $id the notification number
136+
* @param int $id the notification number
137137
*
138138
* @return array
139139
*/

lib/Github/Api/CurrentUser/PublicKeys.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ public function all()
2828
*
2929
* @link https://developer.github.com/v3/users/keys/
3030
*
31-
* @param string $id
31+
* @param int $id
3232
*
3333
* @return array
3434
*/
@@ -62,7 +62,7 @@ public function create(array $params)
6262
*
6363
* @link https://developer.github.com/v3/users/keys/
6464
*
65-
* @param string $id
65+
* @param int $id
6666
*
6767
* @return array
6868
*/

lib/Github/Api/Deployment.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,8 @@ public function create($username, $repository, array $params)
6868
*
6969
* @param string $username the username
7070
* @param string $repository the repository
71-
* @param string $id the deployment number
72-
* @param array $params The information about the deployment update.
71+
* @param int $id the deployment number
72+
* @param array $params The information about the deployment update.
7373
* Must include a "state" field of pending, success, error, or failure.
7474
* May also be given a target_url and description, ßee link for more details.
7575
* @return array information about the deployment

lib/Github/Api/Issue.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ public function org($organization, $state, array $params = array())
104104
*
105105
* @param string $username the username
106106
* @param string $repository the repository
107-
* @param string $id the issue number
107+
* @param int $id the issue number
108108
*
109109
* @return array information about the issue
110110
*/
@@ -143,7 +143,7 @@ public function create($username, $repository, array $params)
143143
*
144144
* @param string $username the username
145145
* @param string $repository the repository
146-
* @param string $id the issue number
146+
* @param int $id the issue number
147147
* @param array $params key=>value user attributes to update.
148148
* key can be title or body
149149
*
@@ -161,7 +161,7 @@ public function update($username, $repository, $id, array $params)
161161
*
162162
* @param string $username
163163
* @param string $repository
164-
* @param string $id
164+
* @param int $id
165165
*
166166
* @return string
167167
*/
@@ -177,7 +177,7 @@ public function lock($username, $repository, $id)
177177
*
178178
* @param string $username
179179
* @param string $repository
180-
* @param string $id
180+
* @param int $id
181181
*
182182
* @return string
183183
*/

lib/Github/Api/PullRequest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ public function all($username, $repository, array $params = array())
7575
*
7676
* @param string $username the username
7777
* @param string $repository the repository
78-
* @param string $id the ID of the pull request for which details are retrieved
78+
* @param int $id the ID of the pull request for which details are retrieved
7979
*
8080
* @return array|string pull request details
8181
*/
@@ -101,7 +101,7 @@ public function files($username, $repository, $id)
101101
*
102102
* @param string $username the username
103103
* @param string $repository the repository
104-
* @param string $id the ID of the pull request for which statuses are retrieved
104+
* @param int $id the ID of the pull request for which statuses are retrieved
105105
*
106106
* @return array array of statuses for the project
107107
*/

0 commit comments

Comments
 (0)