Add support to get all milestones.

klaude · klaude · commit 96af37ac1110 · 2014-07-07T17:27:59.000-05:00
The GitHub API allows you to retrieve open, closed, or all milestones.
Add support to retrieve all milestones in addition to just the open or
the closed ones.
diff --git a/lib/Github/Api/Issue/Milestones.php b/lib/Github/Api/Issue/Milestones.php
@@ -13,7 +13,7 @@ class Milestones extends AbstractApi
 {
     public function all($username, $repository, array $params = array())
     {
-        if (isset($params['state']) && !in_array($params['state'], array('open', 'closed'))) {
+        if (isset($params['state']) && !in_array($params['state'], array('open', 'closed', 'all'))) {
             $params['state'] = 'open';
         }
         if (isset($params['sort']) && !in_array($params['sort'], array('due_date', 'completeness'))) {

Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@ class Milestones extends AbstractApi`
`13`	`13`	`{`
`14`	`14`	`public function all($username, $repository, array $params = array())`
`15`	`15`	`{`
`16`		`- if (isset($params['state']) && !in_array($params['state'], array('open', 'closed'))) {`
	`16`	`+ if (isset($params['state']) && !in_array($params['state'], array('open', 'closed', 'all'))) {`
`17`	`17`	`$params['state'] = 'open';`
`18`	`18`	`}`
`19`	`19`	`if (isset($params['sort']) && !in_array($params['sort'], array('due_date', 'completeness'))) {`