Refactor Dual Methods To Single, and Fix Test

- In order to match existing API conventions, the two method solution for branch/tag was consolidated into one method and extra data in the third argument.

- Updated ReferencesTest.php to only test the single method

Author: nickpoulos

lib/Github/Api/GitData/References.php

@@ -26,31 +26,19 @@ public function all($username, $repository)
     }
 
     /**
-     * Get all matching references for a particular branch of a repository.
+     * Get all matching references for the supplied reference name
      *
-     * @param string $username
-     * @param string $repository
-     * @param string $branch
-     *
-     * @return array
-     */
-    public function matchingBranch(string $username, string $repository, string $branch): array
-    {
-        return $this->get('/repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/git/matching-refs/heads/'.rawurlencode($branch));
-    }
-
-    /**
-     * Get all matching references for a particular branch of a repository.
+     * https://developer.github.com/v3/git/refs/#list-matching-references
      *
      * @param string $username
      * @param string $repository
-     * @param string $tag
+     * @param string $reference
      *
      * @return array
      */
-    public function matchingTag(string $username, string $repository, string $tag): array
+    public function matching(string $username, string $repository, string $reference): array
     {
-        return $this->get('/repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/git/matching-refs/tags/'.rawurlencode($tag));
+        return $this->get('/repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/git/matching-refs/'.rawurlencode($reference));
     }
 
     /**

test/Github/Tests/Api/GitData/ReferencesTest.php

@@ -74,33 +74,17 @@ public function shouldGetAllRepoReferences()
     /**
      * @test
      */
-    public function shouldGetAllMatchingBranchRepoReferences()
+    public function shouldGetAllMatchingReferences()
     {
         $expectedValue = [['reference' => 'some data']];
 
         $api = $this->getApiMock();
         $api->expects($this->once())
             ->method('get')
-            ->with('/repos/l3l0/l3l0repo/git/matching-refs/heads/branchName')
+            ->with('/repos/l3l0/l3l0repo/git/matching-refs/refName')
             ->will($this->returnValue($expectedValue));
 
-        $this->assertEquals($expectedValue, $api->matchingBranch('l3l0', 'l3l0repo', 'branchName'));
-    }
-
-    /**
-     * @test
-     */
-    public function shouldGetAllMatchingTagRepoReferences()
-    {
-        $expectedValue = [['reference' => 'some data']];
-
-        $api = $this->getApiMock();
-        $api->expects($this->once())
-            ->method('get')
-            ->with('/repos/l3l0/l3l0repo/git/matching-refs/tags/tagName')
-            ->will($this->returnValue($expectedValue));
-
-        $this->assertEquals($expectedValue, $api->matchingTag('l3l0', 'l3l0repo', 'tagName'));
+        $this->assertEquals($expectedValue, $api->matching('l3l0', 'l3l0repo', 'refName'));
     }
 
     /**