Skip to content

Commit 7d9a5b7

Browse files
authored
minor #982 Improved bc check (acrobat)
This PR was merged into the 2.x branch. Discussion ---------- Only run the BC check on PR's and use the PR base branch as target branch to check the BC breaks against, this won't make the BC check fail false-positive on 2.x pr's Commits ------- e182f74 Improved bc check
2 parents a3fd346 + e182f74 commit 7d9a5b7

File tree

2 files changed

+18
-9
lines changed

2 files changed

+18
-9
lines changed
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
name: "BC check"
2+
3+
on:
4+
pull_request:
5+
6+
jobs:
7+
roave_bc_check:
8+
name: "Roave BC check"
9+
runs-on: ubuntu-latest
10+
steps:
11+
- uses: actions/checkout@v2
12+
with:
13+
fetch-depth: 0
14+
15+
- name: Roave BC Check
16+
uses: docker://nyholm/roave-bc-check-ga
17+
with:
18+
args: --from=${{ github.event.pull_request.base.sha }}

.github/workflows/ci.yml

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -28,15 +28,6 @@ jobs:
2828
- name: Run phpunit
2929
run: vendor/bin/phpunit --verbose
3030

31-
roave_bc_check:
32-
name: Roave BC Check
33-
runs-on: ubuntu-latest
34-
steps:
35-
- uses: actions/checkout@v2
36-
37-
- name: Roave BC Check
38-
uses: docker://nyholm/roave-bc-check-ga
39-
4031
phpstan:
4132
name: PHPStan
4233
runs-on: ubuntu-latest

0 commit comments

Comments
 (0)