Skip to content

Commit 3cb9b2c

Browse files
committed
Fix test after previous commit
1 parent 1aa026d commit 3cb9b2c

File tree

9 files changed

+60
-9
lines changed

9 files changed

+60
-9
lines changed

test/Github/Tests/ClientTest.php

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
namespace Github\Tests;
44

55
use Github\Client;
6-
use Github\HttpClient\Listener\AuthListener;
76
use Github\Exception\InvalidArgumentException;
87

98
class ClientTest extends \PHPUnit_Framework_TestCase
@@ -34,10 +33,10 @@ public function shouldPassHttpClientInterfaceToConstructor()
3433
*/
3534
public function shouldAuthenticateUsingAllGivenParameters($login, $password, $method)
3635
{
37-
$httpClient = $this->getHttpClientMock(array('addListener'));
36+
$httpClient = $this->getHttpClientMock(array('authenticate'));
3837
$httpClient->expects($this->once())
39-
->method('addListener')
40-
->with(new AuthListener($method, array('tokenOrLogin' => $login, 'password' => $password)));
38+
->method('authenticate')
39+
->with($login, $password, $method);
4140

4241
$client = new Client($httpClient);
4342
$client->authenticate($login, $password, $method);
@@ -59,10 +58,10 @@ public function getAuthenticationFullData()
5958
*/
6059
public function shouldAuthenticateUsingGivenParameters($token, $method)
6160
{
62-
$httpClient = $this->getHttpClientMock(array('addListener'));
61+
$httpClient = $this->getHttpClientMock(array('authenticate'));
6362
$httpClient->expects($this->once())
64-
->method('addListener')
65-
->with(new AuthListener($method, array('tokenOrLogin' => $token, 'password' => null)));
63+
->method('authenticate')
64+
->with($token, null, $method);
6665

6766
$client = new Client($httpClient);
6867
$client->authenticate($token, $method);

test/Github/Tests/Functional/CommitTest.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22

33
namespace Github\Tests\Functional;
44

5+
/**
6+
* @group functional
7+
*/
58
class CommitTest extends TestCase
69
{
710
/**

test/Github/Tests/Functional/GistTest.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22

33
namespace Github\Tests\Functional;
44

5+
/**
6+
* @group functional
7+
*/
58
class GistTest extends TestCase
69
{
710
/**

test/Github/Tests/Functional/IssueCommentTest.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22

33
namespace Github\Tests\Functional;
44

5+
/**
6+
* @group functional
7+
*/
58
class IssueCommentTest extends TestCase
69
{
710
/**

test/Github/Tests/Functional/MarkdownTest.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22

33
namespace Github\Tests\Functional;
44

5+
/**
6+
* @group functional
7+
*/
58
class MarkdownTest extends TestCase
69
{
710
/**

test/Github/Tests/Functional/RepoCommentTest.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22

33
namespace Github\Tests\Functional;
44

5+
/**
6+
* @group functional
7+
*/
58
class RepoCommentTest extends TestCase
69
{
710
/**

test/Github/Tests/Functional/RepoTest.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22

33
namespace Github\Tests\Functional;
44

5+
/**
6+
* @group functional
7+
*/
58
class RepoTest extends TestCase
69
{
710
/**

test/Github/Tests/Functional/UserTest.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22

33
namespace Github\Tests\Functional;
44

5+
/**
6+
* @group functional
7+
*/
58
class UsetTest extends TestCase
69
{
710
/**

test/Github/Tests/HttpClient/HttpClientTest.php

Lines changed: 33 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
namespace Github\Tests\HttpClient;
44

5+
use Github\Client;
56
use Github\HttpClient\HttpClient;
67
use Github\HttpClient\Message\Request;
78
use Github\HttpClient\Message\Response;
@@ -32,6 +33,29 @@ public function shouldBeAbleToSetOption()
3233
$this->assertEquals(666, $httpClient->getOption('timeout'));
3334
}
3435

36+
/**
37+
* @test
38+
* @dataProvider getAuthenticationFullData
39+
*/
40+
public function shouldAuthenticateUsingAllGivenParameters($login, $password, $method)
41+
{
42+
$client = new TestHttpClient();
43+
$client->authenticate($login, $password, $method);
44+
45+
$this->assertCount(2, $client->listeners);
46+
$this->assertInstanceOf('Github\HttpClient\Listener\AuthListener', $client->listeners['Github\HttpClient\Listener\AuthListener']);
47+
}
48+
49+
public function getAuthenticationFullData()
50+
{
51+
return array(
52+
array('login', 'password', Client::AUTH_HTTP_PASSWORD),
53+
array('token', null, Client::AUTH_HTTP_TOKEN),
54+
array('token', null, Client::AUTH_URL_TOKEN),
55+
array('client_id', 'client_secret', Client::AUTH_URL_CLIENT_ID),
56+
);
57+
}
58+
3559
/**
3660
* @test
3761
*/
@@ -186,15 +210,22 @@ public function shouldThrowExceptionWhenApiIsExceeded()
186210
$httpClient->get($path, $parameters, $headers);
187211
}
188212

189-
protected function getBrowserMock()
213+
protected function getBrowserMock(array $methods = array())
190214
{
191-
return $this->getMock('Buzz\Client\ClientInterface', array('setTimeout', 'setVerifyPeer', 'send'));
215+
return $this->getMock(
216+
'Buzz\Client\ClientInterface',
217+
array_merge(
218+
array('setTimeout', 'setVerifyPeer', 'send'),
219+
$methods
220+
)
221+
);
192222
}
193223
}
194224

195225
class TestHttpClient extends HttpClient
196226
{
197227
public $fakeResponse;
228+
public $listeners;
198229

199230
public function getOption($name, $default = null)
200231
{

0 commit comments

Comments
 (0)