Skip to content

Commit ed313f7

Browse files
committed
mkay better test
1 parent cfdf512 commit ed313f7

File tree

1 file changed

+25
-20
lines changed

1 file changed

+25
-20
lines changed

packages/react-query/src/__tests__/transition.test.tsx

Lines changed: 25 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,13 @@
1-
import { afterAll, beforeAll, describe, expect, it, } from 'vitest'
2-
import * as React from 'react'
31
import {
42
createRenderStream,
5-
disableActEnvironment,
6-
useTrackRenders,
3+
useTrackRenders
74
} from '@testing-library/react-render-stream'
5+
import * as React from 'react'
6+
import { afterAll, beforeAll, describe, expect, it, } from 'vitest'
87
import { QueryClientProvider, useQuery } from '..'
98
import { QueryCache } from '../index'
109
import { createQueryClient, queryKey, sleep } from './utils'
1110

12-
let disableActReturn: ReturnType<typeof disableActEnvironment>
13-
beforeAll(() => {
14-
disableActReturn = disableActEnvironment()
15-
})
16-
afterAll(() => {
17-
disableActReturn.cleanup()
18-
})
19-
2011

2112
describe('react transitions', () => {
2213
const queryCache = new QueryCache()
@@ -110,7 +101,7 @@ describe('react transitions', () => {
110101
return { promise, resolve: resolve!, reject: reject! }
111102
}
112103

113-
it.only('should handle parallel queries with shared parent key in transition', async () => {
104+
it.only('should handle parallel queries with shared parent key in transition', {repeats: 10}, async () => {
114105
const renderStream = createRenderStream({ snapshotDOM: true })
115106

116107
let deferredA = createDeferred<void>()
@@ -131,7 +122,11 @@ describe('react transitions', () => {
131122
staleTime: 1000,
132123
})
133124

125+
126+
134127
const data = React.use(query.promise)
128+
129+
135130
return <div>A data: {data}</div>
136131
}
137132

@@ -145,9 +140,9 @@ describe('react transitions', () => {
145140
const query = useQuery({
146141
queryKey: ['B', props.parentId],
147142
queryFn: async () => {
148-
console.log('B loading', props.parentId)
143+
149144
await deferredB.promise
150-
console.log('B loaded', props.parentId)
145+
151146
deferredB = createDeferred()
152147
return `B-${props.parentId}`
153148
},
@@ -158,7 +153,7 @@ describe('react transitions', () => {
158153

159154
const data = React.use(query.promise)
160155

161-
console.log('render B', data)
156+
162157
return <div>B data: {data}</div>
163158
}
164159
function ComponentBLoading() {
@@ -215,10 +210,20 @@ describe('react transitions', () => {
215210
deferredB.resolve()
216211

217212
{
218-
const { renderedComponents, withinDOM } = await renderStream.takeRender()
219-
withinDOM().getByText('A data: A-1')
220-
withinDOM().getByText('B data: B-1')
221-
expect(renderedComponents).toEqual([Parent, ComponentB, ComponentA])
213+
// first render
214+
const firstRender = await renderStream.takeRender()
215+
firstRender.withinDOM().getByText('A data: A-0')
216+
firstRender.withinDOM().getByText('B data: B-0')
217+
218+
// second render
219+
const secondRender = await renderStream.takeRender()
220+
secondRender.withinDOM().getByText('A data: A-1')
221+
secondRender.withinDOM().getByText('B data: B-0')
222+
223+
// third render
224+
const thirdRender = await renderStream.takeRender()
225+
thirdRender.withinDOM().getByText('A data: A-1')
226+
thirdRender.withinDOM().getByText('B data: B-1')
222227
}
223228

224229
})

0 commit comments

Comments
 (0)