Skip to content

Commit cf2c6ba

Browse files
jbrockmendelJulianWgs
authored andcommitted
CLN: remove redundant _get_unique_index (pandas-dev#42184)
1 parent f200ba1 commit cf2c6ba

File tree

4 files changed

+5
-31
lines changed

4 files changed

+5
-31
lines changed

pandas/core/indexes/base.py

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2754,16 +2754,6 @@ def duplicated(self, keep: Literal["first", "last", False] = "first") -> np.ndar
27542754
return np.zeros(len(self), dtype=bool)
27552755
return self._duplicated(keep=keep)
27562756

2757-
def _get_unique_index(self: _IndexT) -> _IndexT:
2758-
"""
2759-
Returns an index containing unique values.
2760-
2761-
Returns
2762-
-------
2763-
Index
2764-
"""
2765-
return self.unique()
2766-
27672757
# --------------------------------------------------------------------
27682758
# Arithmetic & Logical Methods
27692759

@@ -3200,7 +3190,7 @@ def difference(self, other, sort=None):
32003190

32013191
def _difference(self, other, sort):
32023192

3203-
this = self._get_unique_index()
3193+
this = self.unique()
32043194

32053195
indexer = this.get_indexer_for(other)
32063196
indexer = indexer.take((indexer != -1).nonzero()[0])

pandas/core/indexes/extension.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -364,13 +364,6 @@ def _validate_fill_value(self, value):
364364
"""
365365
return self._data._validate_setitem_value(value)
366366

367-
def _get_unique_index(self):
368-
if self.is_unique:
369-
return self
370-
371-
result = self._data.unique()
372-
return type(self)._simple_new(result, name=self.name)
373-
374367
@doc(Index.map)
375368
def map(self, mapper, na_action=None):
376369
# Try to run function on index first, and then on elements of index

pandas/tests/indexes/multi/test_duplicates.py

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -74,15 +74,6 @@ def test_unique_level(idx, level):
7474
tm.assert_index_equal(result, expected)
7575

7676

77-
def test_get_unique_index(idx):
78-
mi = idx[[0, 1, 0, 1, 1, 0, 0]]
79-
expected = mi._shallow_copy(mi[[0, 1]])
80-
81-
result = mi._get_unique_index()
82-
assert result.unique
83-
tm.assert_index_equal(result, expected)
84-
85-
8677
def test_duplicate_multiindex_codes():
8778
# GH 17464
8879
# Make sure that a MultiIndex with duplicate levels throws a ValueError

pandas/tests/indexes/test_common.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ def test_copy_and_deepcopy(self, index_flat):
126126
new_copy = index.copy(deep=True, name="banana")
127127
assert new_copy.name == "banana"
128128

129-
def test_unique(self, index_flat):
129+
def test_unique_level(self, index_flat):
130130
# don't test a MultiIndex here (as its tested separated)
131131
index = index_flat
132132

@@ -147,7 +147,7 @@ def test_unique(self, index_flat):
147147
with pytest.raises(KeyError, match=msg):
148148
index.unique(level="wrong")
149149

150-
def test_get_unique_index(self, index_flat):
150+
def test_unique(self, index_flat):
151151
# MultiIndex tested separately
152152
index = index_flat
153153
if not len(index):
@@ -164,7 +164,7 @@ def test_get_unique_index(self, index_flat):
164164
except NotImplementedError:
165165
pass
166166

167-
result = idx._get_unique_index()
167+
result = idx.unique()
168168
tm.assert_index_equal(result, idx_unique)
169169

170170
# nans:
@@ -195,7 +195,7 @@ def test_get_unique_index(self, index_flat):
195195

196196
expected = idx_unique_nan
197197
for i in [idx_nan, idx_unique_nan]:
198-
result = i._get_unique_index()
198+
result = i.unique()
199199
tm.assert_index_equal(result, expected)
200200

201201
def test_searchsorted_monotonic(self, index_flat):

0 commit comments

Comments
 (0)