Conda.activate more closely reflects actual conda activate

Author: Christopher Doris

Project.toml

@@ -9,6 +9,7 @@ Compat = "34da2185-b29b-5c13-b0c7-acf172513d20"
 Conda = "8f4d0f93-b110-5947-807f-2305c1781a2d"
 Dates = "ade2ca70-3891-5945-98fb-dc099432e06a"
 IteratorInterfaceExtensions = "82899510-4779-5014-852e-03e436cf321d"
+JSON = "682c06a0-de6a-54ab-a142-c8b1cf79cde6"
 Libdl = "8f399da3-3557-5675-b5ff-fb832c97cbdb"
 LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
 MacroTools = "1914dd2f-81c6-5fcd-8719-6d5c9610ff09"

src/conda.jl

@@ -1,6 +1,6 @@
 module Conda
 
-import ..External
+import ..External, JSON
 
 const _env = Ref("")
 
@@ -15,22 +15,20 @@ const ENV_STACK = Vector{Dict{String,String}}()
 function activate()
     push!(ENV_STACK, copy(ENV))
     e = env()
-    # these steps imitate a minimal "conda activate"
-    # TODO: run "conda shell.posix activate ..." or "conda shell.cmd.exe activate ...", capture the resulting environment, and set that here
-    oldlvl = parse(Int, get(ENV, "CONDA_SHLVL", "0"))
-    if oldlvl > 0
-        ENV["CONDA_PREFIX_$oldlvl"] = ENV["CONDA_PREFIX"]
+    shell = Sys.iswindows() ? "cmd.exe" : "posix"
+    pathsep = Sys.iswindows() ? ";" : ":"
+    # ask conda for a JSON description of how it would activate the environment
+    info = JSON.parse(read(External.Conda._set_conda_env(`$(External.Conda.conda) shell.$shell+json activate $e`), String))
+    # make these changes
+    # TODO: we currently ignore info["scripts"]["activate"]
+    #   run these in a subshell, print the resulting environment vars, and merge into ENV
+    #   (or just run the full `conda shell.* activate *` script)
+    ENV["PATH"] = join(info["path"]["PATH"], pathsep)
+    for k in info["vars"]["unset"]
+        delete!(ENV, k)
     end
-    ENV["CONDA_SHLVL"] = string(oldlvl+1)
     ENV["CONDA_PREFIX"] = e
-    ENV["CONDA_DEFAULT_ENV"] = e
-    ENV["CONDA_PROMPT_MODIFIER"] = "($e) "
-    ENV["_CE_M"] = ""
-    ENV["_CE_CONDA"] = ""
-    ENV["CONDA_PYTHON_EXE"] = python_exe()
-    oldpath = get(ENV, "PATH", "")
-    pathsep = Sys.iswindows() ? ";" : ":"
-    ENV["PATH"] = oldpath == "" ? External.Conda.bin_dir(e) : (External.Conda.bin_dir(e) * pathsep * oldpath)
+    merge!(ENV, info["vars"]["export"])
     return
 end