Skip to content

Commit fd58b64

Browse files
committed
[BREAKING] Remove the verbose field, and use the Julia logging system instead
1 parent a696545 commit fd58b64

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

src/slurmmanager.jl

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,11 @@ The environment variables `SLURM_JOB_ID` or `SLURM_JOBID` and `SLURM_NTASKS` mus
77
mutable struct SlurmManager <: ClusterManager
88
jobid::Int
99
ntasks::Int
10-
verbose::Bool
1110
launch_timeout::Float64
1211
srun_post_exit_sleep::Float64
1312
srun_proc
1413

15-
function SlurmManager(;verbose=false, launch_timeout=60.0, srun_post_exit_sleep=0.01)
14+
function SlurmManager(; launch_timeout=60.0, srun_post_exit_sleep=0.01)
1615

1716
jobid =
1817
if "SLURM_JOB_ID" in keys(ENV)
@@ -39,7 +38,7 @@ mutable struct SlurmManager <: ClusterManager
3938
jobid = parse(Int, jobid)
4039
ntasks = parse(Int, ntasks)
4140

42-
new(jobid, ntasks, verbose, launch_timeout, srun_post_exit_sleep, nothing)
41+
new(jobid, ntasks, launch_timeout, srun_post_exit_sleep, nothing)
4342
end
4443
end
4544

@@ -201,7 +200,7 @@ function Distributed.launch(manager::SlurmManager, params::Dict, instances_arr::
201200
write(manager.srun_proc, "\n")
202201

203202
t = @async for i in 1:manager.ntasks
204-
manager.verbose && println("connecting to worker $i out of $(manager.ntasks)")
203+
@debug "connecting to worker $i out of $(manager.ntasks)"
205204

206205
line = readline(manager.srun_proc)
207206
m = match(r".*:(\d*)#(.*)", line)

0 commit comments

Comments
 (0)