Feat: separate getConfigPath and setConfig for future which-config

Author: JPeer264

__tests__/Config.ts

@@ -69,24 +69,36 @@ it('read global config', () => {
   const sgcrc = json.readToObjSync(path.join(fixtures, '.sgcrc'));
 
   fs.writeFileSync(path.join(homedir, '.sgcrc'), JSON.stringify(sgcrc));
-  expect(new Config().config).toEqual(sgcrc);
+
+  const { config } = new Config();
+
   fs.removeSync(path.join(homedir, '.sgcrc'));
+
+  expect(config).toEqual(sgcrc);
 });
 
 it('read local config from `sgc.config.js`', () => {
   const sgcrc = json.readToObjSync(path.join(fixtures, '.sgcrc'));
 
   fs.writeFileSync(path.join(cwd, 'sgc.config.js'), `module.exports = (${JSON.stringify(sgcrc)})`);
-  expect(new Config().config).toEqual(sgcrc);
+
+  const { config } = new Config();
+
   fs.removeSync(path.join(cwd, 'sgc.config.js'));
+
+  expect(config).toEqual(sgcrc);
 });
 
 it('read global config from `sgc.config.js`', () => {
   const sgcrc = json.readToObjSync(path.join(fixtures, '.sgcrc'));
 
   fs.writeFileSync(path.join(homedir, 'sgc.config.js'), `module.exports = (${JSON.stringify(sgcrc)})`);
-  expect(new Config().config).toEqual(sgcrc);
+
+  const { config } = new Config();
+
   fs.removeSync(path.join(homedir, 'sgc.config.js'));
+
+  expect(config).toEqual(sgcrc);
 });
 
 it('read a .sgcrc_default from a deep nested cwd', () => {

lib/Config.ts

@@ -33,11 +33,6 @@ export interface SgcConfig {
   };
 }
 
-const safeRequire = (jsPath: string | null): SgcConfig | false => (
-  // eslint-disable-next-line global-require, import/no-dynamic-require
-  jsPath && fs.existsSync(jsPath) && require(jsPath)
-);
-
 class Config {
   altPath: string | null;
 
@@ -50,19 +45,29 @@ class Config {
     this.setConfig();
   }
 
-  private setConfig(): SgcConfig {
-    const pathString = findup(this.fileName, { cwd: this.altPath || cwd });
-    const localeConfigJS = safeRequire(findup('sgc.config.js', { cwd }));
-    const localeConfig = pathString ? json.readToObjSync<SgcConfig>(pathString) : false;
-    const globalConfigJS = safeRequire(path.join(homedir, 'sgc.config.js'));
-    const globalConfig = json.readToObjSync<SgcConfig>(path.join(homedir, '.sgcrc'));
-    const packageJson = findup('package.json', { cwd });
-    const packageConfig = packageJson
-      ? (json.readToObjSync<{ sgc?: SgcConfig }>(packageJson) || {}).sgc
-      : false;
-    const sgcrcDefaultConfig = json.readToObjSync<SgcConfig>(path.join(__dirname, '..', '.sgcrc')) as SgcConfig;
-    const sgcrcTestDefaultConfig = json.readToObjSync<SgcConfig>(path.join(__dirname, '..', '.sgcrc_default')) as SgcConfig;
-    const sgcrcDefault = sgcrcDefaultConfig || sgcrcTestDefaultConfig;
+  static safeRequire = (jsPath: string | null): SgcConfig | false => (
+    // eslint-disable-next-line global-require, import/no-dynamic-require
+    jsPath && require(jsPath)
+  )
+
+  static safeRead = (configPath: string | null): SgcConfig | false => (
+    !!configPath && json.readToObjSync<SgcConfig>(configPath)
+  )
+
+  static getPath = (configPath: string | null): string | null => (
+    !!configPath && fs.existsSync(configPath) ? configPath : null
+  )
+
+  private getConfigPath(): { path: string; defaultPath: string; type: 'rc' | 'js' | 'pkg' } {
+    // paths
+    const localPath = Config.getPath(findup(this.fileName, { cwd: this.altPath || cwd }));
+    const localJsPath = Config.getPath(findup('sgc.config.js', { cwd }));
+    const globalPath = Config.getPath(path.join(homedir, this.fileName));
+    const globalJsPath = Config.getPath(path.join(homedir, 'sgc.config.js'));
+    const packageJson = Config.getPath(findup('package.json', { cwd }));
+    const defaultPath = Config.getPath(path.join(__dirname, '..', '.sgcrc')) as string;
+    const testDefaultPath = Config.getPath(path.join(__dirname, '..', '.sgcrc_default')) as string;
+    const sgcrcDefault = defaultPath || testDefaultPath;
 
     // priority order (1. highest priority):
     // 1. local config
@@ -73,13 +78,64 @@ class Config {
     // 3. default config
     //   - 1. from ../.sgcrc
     //   - 2. test case ../.sgcrc is renamed to ../.sgcrc_default
-    const config = localeConfigJS
-      || localeConfig
-      || packageConfig
-      || globalConfigJS
-      || globalConfig
+    const configPath = localJsPath
+      || localPath
+      || packageJson
+      || globalJsPath
+      || globalPath
       || sgcrcDefault;
 
+    let type: 'rc' | 'js' | 'pkg';
+
+    switch (path.extname(configPath)) {
+      case '.json':
+        type = 'pkg';
+        break;
+
+      case '.js':
+        type = 'js';
+        break;
+
+      default:
+        type = 'rc';
+        break;
+    }
+
+    return {
+      path: configPath,
+      defaultPath: sgcrcDefault,
+      type,
+    };
+  }
+
+  private setConfig(): SgcConfig {
+    const configPath = this.getConfigPath();
+    const sgcrcDefault: SgcConfig = Config.safeRead(configPath.defaultPath) as SgcConfig;
+
+    let config: SgcConfig = sgcrcDefault;
+    let readConfig: SgcConfig | false;
+
+    switch (configPath.type) {
+      case 'js':
+        readConfig = Config.safeRequire(configPath.path);
+        break;
+
+      case 'pkg':
+        readConfig = (
+          json.readToObjSync<{ sgc: SgcConfig }>(configPath.path)
+          || { sgc: false as false }
+        ).sgc;
+        break;
+
+      default:
+      case 'rc':
+        readConfig = Config.safeRead(configPath.path);
+    }
+
+    if (readConfig) {
+      config = readConfig;
+    }
+
     // set defaults which are necessary
     const modifiedConfig = merge({}, sgcrcDefault, config);