no autofix if have comments

Author: tanhauhau

lib/rules/sort-styles.js

@@ -49,30 +49,29 @@ module.exports = (context) => {
     });
   }
 
-  function getActualRange(node) {
-    const range = [].concat(node.range);
-    range[0] = sourceCode
-      .getCommentsBefore(node)
-      .reduce((start, comment) => Math.min(start, comment.range[0]), range[0]);
-    return range;
-  }
-
   function report(array, type, node, prev, current) {
     const currentName = getStylePropertyIdentifier(current);
     const prevName = getStylePropertyIdentifier(prev);
+    const hasComments = array
+      .map(prop => sourceCode.getComments(prop))
+      .reduce(
+        (hasComment, comment) =>
+          hasComment || comment.leading.length > 0 || comment.trailing > 0,
+        false
+      );
+
     context.report({
       node,
       message: `Expected ${type} to be in ${order}ending order. '${currentName}' should be before '${prevName}'.`,
       loc: current.key.loc,
-      fix(fixer) {
+      fix: hasComments ? undefined : (fixer) => {
         const sortedArray = sort(array);
         return array
           .map((item, i) => {
             if (item !== sortedArray[i]) {
-              const actualRange = getActualRange(sortedArray[i]);
-              return fixer.replaceTextRange(
-                getActualRange(item),
-                sourceCode.text.slice(actualRange[0], actualRange[1])
+              return fixer.replaceText(
+                item,
+                sourceCode.getText(sortedArray[i])
               );
             }
             return null;

tests/lib/rules/sort-styles.js

@@ -398,90 +398,22 @@ const tests = {
         })
       `,
       output: `
-        const styles = StyleSheet.create({
-          a: {
-            a: 1,
-            b: 2,
-            // comments 1
-            c: 3,
-            d: 4,
-          },
-          // comments 2
-          b: {
-            a: 1,
-            b: 2,
-          },
-          c: {},
-          d: {},
-          // comments 3
-        })
-      `,
-      errors: [
-        {
-          message:
-            "Expected style properties to be in ascending order. 'c' should be before 'd'.",
-        },
-        {
-          message:
-            "Expected class names to be in ascending order. 'c' should be before 'd'.",
-        },
-      ],
-    },
-    {
-      code: `
         const styles = StyleSheet.create({
           a: {
             d: 4,
-            // singleline 1
-            // singleline 2
-            // singleline 3
+            // comments 1
             c: 3,
             a: 1,
             b: 2,
           },
           d: {},
           c: {},
-          /*
-          multiline 1
-          */
-          /*
-          multiline 2
-          */
-          /*
-          multiline 3
-          */
-          b: {
-            a: 1,
-            b: 2,
-          },
-        })
-      `,
-      output: `
-        const styles = StyleSheet.create({
-          a: {
-            a: 1,
-            b: 2,
-            // singleline 1
-            // singleline 2
-            // singleline 3
-            c: 3,
-            d: 4,
-          },
-          /*
-          multiline 1
-          */
-          /*
-          multiline 2
-          */
-          /*
-          multiline 3
-          */
+          // comments 2
           b: {
             a: 1,
             b: 2,
           },
-          c: {},
-          d: {},
+          // comments 3
         })
       `,
       errors: [