Find StyleSheet declarations that are not variables

Fixes #214

Author: draperunner

lib/rules/no-color-literals.js

@@ -31,7 +31,7 @@ module.exports = Components.detect((context) => {
   }
 
   return {
-    VariableDeclarator: (node) => {
+    CallExpression: (node) => {
       if (astHelpers.isStyleSheetDeclaration(node, context.settings)) {
         const styles = astHelpers.getStyleDeclarations(node);
 

lib/rules/no-unused-styles.js

@@ -42,9 +42,9 @@ module.exports = Components.detect((context, components) => {
     },
 
     VariableDeclarator: function (node) {
-      if (astHelpers.isStyleSheetDeclaration(node, context.settings)) {
+      if (astHelpers.isStyleSheetDeclaration(node.init, context.settings)) {
         const styleSheetName = astHelpers.getStyleSheetName(node);
-        const styles = astHelpers.getStyleDeclarations(node);
+        const styles = astHelpers.getStyleDeclarations(node.init);
 
         styleSheets.add(styleSheetName, styles);
       }

lib/rules/sort-styles.js

@@ -57,7 +57,7 @@ module.exports = (context) => {
   }
 
   return {
-    VariableDeclarator: function (node) {
+    CallExpression: function (node) {
       if (!isStyleSheetDeclaration(node, context.settings)) {
         return;
       }

lib/util/stylesheet.js

@@ -99,21 +99,21 @@ const astHelpers = {
   containsStyleSheetObject: function (node, objectNames) {
     return Boolean(
       node &&
-      node.init &&
-      node.init.callee &&
-      node.init.callee.object &&
-      node.init.callee.object.name &&
-      objectNames.includes(node.init.callee.object.name)
+      node.type === 'CallExpression' &&
+      node.callee &&
+      node.callee.object &&
+      node.callee.object.name &&
+      objectNames.includes(node.callee.object.name)
     );
   },
 
   containsCreateCall: function (node) {
     return Boolean(
       node &&
-      node.init &&
-      node.init.callee &&
-      node.init.callee.property &&
-      node.init.callee.property.name === 'create'
+      node &&
+      node.callee &&
+      node.callee.property &&
+      node.callee.property.name === 'create'
     );
   },
 
@@ -138,13 +138,11 @@ const astHelpers = {
   getStyleDeclarations: function (node) {
     if (
       node &&
-      node.init &&
-      node.init.arguments &&
-      node.init.arguments[0] &&
-      node.init.arguments[0].properties
+      node.arguments &&
+      node.arguments[0] &&
+      node.arguments[0].properties
     ) {
       return node
-        .init
         .arguments[0]
         .properties
         .filter(property => property.type === 'Property');

tests/lib/rules/sort-styles.js

@@ -137,6 +137,34 @@ const tests = {
         message: 'Expected style properties to be in ascending order. \'x\' should be before \'y\'.',
       }],
     },
+    {
+      code: `
+        StyleSheet.create({
+          myClass: {
+            y: 2,
+            x: 1,
+            z: 3,
+          },
+        })
+        `,
+      errors: [{
+        message: 'Expected style properties to be in ascending order. \'x\' should be before \'y\'.',
+      }],
+    },
+    {
+      code: `
+        export default StyleSheet.create({
+          myClass: {
+            y: 2,
+            x: 1,
+            z: 3,
+          },
+        })
+        `,
+      errors: [{
+        message: 'Expected style properties to be in ascending order. \'x\' should be before \'y\'.',
+      }],
+    },
     {
       code: `
         const styles = StyleSheet.create({
@@ -208,4 +236,4 @@ const config = {
 tests.valid.forEach(t => Object.assign(t, config));
 tests.invalid.forEach(t => Object.assign(t, config));
 
-ruleTester.run('no-unused-styles', rule, tests);
+ruleTester.run('sort-styles', rule, tests);