Find StyleSheet declarations that are not variables

Fixes #214

Author: draperunner

README.md

@@ -64,6 +64,14 @@ In order to whitelist all *browser-like* globals, add `react-native/react-native
 }
 ```
 
+To use another stylesheet providers.
+
+```json
+settings: {
+    'react-native/style-sheet-object-names': ['EStyleSheet', 'OtherStyleSheet', 'PStyleSheet']
+}
+```
+
 Finally, enable all of the rules that you would like to use.
 
 ```json

lib/rules/no-color-literals.js

@@ -31,7 +31,7 @@ module.exports = Components.detect((context) => {
   }
 
   return {
-    VariableDeclarator: (node) => {
+    CallExpression: (node) => {
       if (astHelpers.isStyleSheetDeclaration(node, context.settings)) {
         const styles = astHelpers.getStyleDeclarations(node);
 

lib/rules/no-unused-styles.js

@@ -41,7 +41,7 @@ module.exports = Components.detect((context, components) => {
       }
     },
 
-    VariableDeclarator: function (node) {
+    CallExpression: function (node) {
       if (astHelpers.isStyleSheetDeclaration(node, context.settings)) {
         const styleSheetName = astHelpers.getStyleSheetName(node);
         const styles = astHelpers.getStyleDeclarations(node);

lib/rules/sort-styles.js

@@ -12,9 +12,11 @@
 const { astHelpers } = require('../util/stylesheet');
 
 const {
-  getStyleDeclarations,
+  getStyleDeclarationsChunks,
+  getPropertiesChunks,
   getStylePropertyIdentifier,
   isStyleSheetDeclaration,
+  isEitherShortHand,
 } = astHelpers;
 
 //------------------------------------------------------------------------------
@@ -28,13 +30,54 @@ module.exports = (context) => {
   const ignoreStyleProperties = options.ignoreStyleProperties;
   const isValidOrder = order === 'asc' ? (a, b) => a <= b : (a, b) => a >= b;
 
-  function report(type, node, prev, current) {
+  const sourceCode = context.getSourceCode();
+
+  function sort(array) {
+    return [].concat(array).sort((a, b) => {
+      const identifierA = getStylePropertyIdentifier(a);
+      const identifierB = getStylePropertyIdentifier(b);
+
+      let sortOrder = 0;
+      if (isEitherShortHand(identifierA, identifierB)) {
+        return a.range[0] - b.range[0];
+      } else if (identifierA < identifierB) {
+        sortOrder = -1;
+      } else if (identifierA > identifierB) {
+        sortOrder = 1;
+      }
+      return sortOrder * (order === 'asc' ? 1 : -1);
+    });
+  }
+
+  function report(array, type, node, prev, current) {
     const currentName = getStylePropertyIdentifier(current);
     const prevName = getStylePropertyIdentifier(prev);
+    const hasComments = array
+      .map(prop => sourceCode.getComments(prop))
+      .reduce(
+        (hasComment, comment) =>
+          hasComment || comment.leading.length > 0 || comment.trailing > 0,
+        false
+      );
+
     context.report({
       node,
       message: `Expected ${type} to be in ${order}ending order. '${currentName}' should be before '${prevName}'.`,
       loc: current.key.loc,
+      fix: hasComments ? undefined : (fixer) => {
+        const sortedArray = sort(array);
+        return array
+          .map((item, i) => {
+            if (item !== sortedArray[i]) {
+              return fixer.replaceText(
+                item,
+                sourceCode.getText(sortedArray[i])
+              );
+            }
+            return null;
+          })
+          .filter(Boolean);
+      },
     });
   }
 
@@ -50,38 +93,52 @@ module.exports = (context) => {
       const prevName = getStylePropertyIdentifier(previous);
       const currentName = getStylePropertyIdentifier(current);
 
+      if (
+        arrayName === 'style properties' &&
+        isEitherShortHand(prevName, currentName)
+      ) {
+        return;
+      }
+
       if (!isValidOrder(prevName, currentName)) {
-        return report(arrayName, node, previous, current);
+        return report(array, arrayName, node, previous, current);
       }
     }
   }
 
   return {
-    VariableDeclarator: function (node) {
+    CallExpression: function (node) {
       if (!isStyleSheetDeclaration(node, context.settings)) {
         return;
       }
 
-      const classDefinitions = getStyleDeclarations(node);
+      const classDefinitionsChunks = getStyleDeclarationsChunks(node);
 
       if (!ignoreClassNames) {
-        checkIsSorted(classDefinitions, 'class names', node);
+        classDefinitionsChunks.forEach((classDefinitions) => {
+          checkIsSorted(classDefinitions, 'class names', node);
+        });
       }
 
       if (ignoreStyleProperties) return;
 
-      classDefinitions.forEach((classDefinition) => {
-        const styleProperties = classDefinition.value.properties;
-        if (!styleProperties || styleProperties.length < 2) {
-          return;
-        }
-
-        checkIsSorted(styleProperties, 'style properties', node);
+      classDefinitionsChunks.forEach((classDefinitions) => {
+        classDefinitions.forEach((classDefinition) => {
+          const styleProperties = classDefinition.value.properties;
+          if (!styleProperties || styleProperties.length < 2) {
+            return;
+          }
+          const stylePropertyChunks = getPropertiesChunks(styleProperties);
+          stylePropertyChunks.forEach((stylePropertyChunk) => {
+            checkIsSorted(stylePropertyChunk, 'style properties', node);
+          });
+        });
       });
     },
   };
 };
 
+module.exports.fixable = 'code';
 module.exports.schema = [
   {
     enum: ['asc', 'desc'],

lib/util/stylesheet.js

@@ -99,21 +99,20 @@ const astHelpers = {
   containsStyleSheetObject: function (node, objectNames) {
     return Boolean(
       node &&
-      node.init &&
-      node.init.callee &&
-      node.init.callee.object &&
-      node.init.callee.object.name &&
-      objectNames.includes(node.init.callee.object.name)
+      node.type === 'CallExpression' &&
+      node.callee &&
+      node.callee.object &&
+      node.callee.object.name &&
+      objectNames.includes(node.callee.object.name)
     );
   },
 
   containsCreateCall: function (node) {
     return Boolean(
       node &&
-      node.init &&
-      node.init.callee &&
-      node.init.callee.property &&
-      node.init.callee.property.name === 'create'
+      node.callee &&
+      node.callee.property &&
+      node.callee.property.name === 'create'
     );
   },
 
@@ -127,32 +126,74 @@ const astHelpers = {
   },
 
   getStyleSheetName: function (node) {
+    if (node && node.parent && node.parent.id) {
+      return node.parent.id.name;
+    }
+  },
+
+  getStyleDeclarations: function (node) {
     if (
       node &&
-      node.id
+      node.type === 'CallExpression' &&
+      node.arguments &&
+      node.arguments[0] &&
+      node.arguments[0].properties
     ) {
-      return node.id.name;
+      return node.arguments[0].properties.filter(property => property.type === 'Property');
     }
+
+    return [];
   },
 
-  getStyleDeclarations: function (node) {
+  getStyleDeclarationsChunks: function (node) {
     if (
       node &&
-      node.init &&
-      node.init.arguments &&
-      node.init.arguments[0] &&
-      node.init.arguments[0].properties
+      node.type === 'CallExpression' &&
+      node.arguments &&
+      node.arguments[0] &&
+      node.arguments[0].properties
     ) {
-      return node
-        .init
-        .arguments[0]
-        .properties
-        .filter(property => property.type === 'Property');
+      const properties = node.arguments[0].properties;
+
+      const result = [];
+      let chunk = [];
+      for (let i = 0; i < properties.length; i += 1) {
+        const property = properties[i];
+        if (property.type === 'Property') {
+          chunk.push(property);
+        } else if (chunk.length) {
+          result.push(chunk);
+          chunk = [];
+        }
+      }
+      if (chunk.length) {
+        result.push(chunk);
+      }
+
+      return result;
     }
 
     return [];
   },
 
+  getPropertiesChunks: function (properties) {
+    const result = [];
+    let chunk = [];
+    for (let i = 0; i < properties.length; i += 1) {
+      const property = properties[i];
+      if (property.type === 'Property') {
+        chunk.push(property);
+      } else if (chunk.length) {
+        result.push(chunk);
+        chunk = [];
+      }
+    }
+    if (chunk.length) {
+      result.push(chunk);
+    }
+    return result;
+  },
+
   getExpressionIdentifier: function (node) {
     if (node) {
       switch (node.type) {
@@ -437,6 +478,16 @@ const astHelpers = {
       return [node.object.name, node.property.name].join('.');
     }
   },
+
+  isEitherShortHand: function (property1, property2) {
+    const shorthands = ['margin', 'padding', 'border', 'flex'];
+    if (shorthands.includes(property1)) {
+      return property2.startsWith(property1);
+    } else if (shorthands.includes(property2)) {
+      return property1.startsWith(property2);
+    }
+    return false;
+  },
 };
 
 module.exports.astHelpers = astHelpers;