From f7aaf1b91748a6cded35d55c46b682d97450fbbb Mon Sep 17 00:00:00 2001 From: David Cortes Date: Tue, 25 Feb 2025 10:26:03 +0100 Subject: [PATCH 1/3] accept inputs without emptyline at the end --- sklbench/utils/common.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sklbench/utils/common.py b/sklbench/utils/common.py index 06486428..2eca531c 100755 --- a/sklbench/utils/common.py +++ b/sklbench/utils/common.py @@ -66,7 +66,7 @@ def read_output_from_command(command: str) -> Tuple[int, str, str]: stderr=sp.PIPE, encoding="utf-8", ) - return res.returncode, res.stdout[:-1], res.stderr[:-1] + return res.returncode, res.stdout.strip(), res.stderr.strip() def hash_from_json_repr(x: JsonTypesUnion, hash_limit: int = 5) -> str: From b5706da5aeebb2a488997f773a9ae51c65600067 Mon Sep 17 00:00:00 2001 From: David Cortes Date: Tue, 25 Feb 2025 11:35:50 +0100 Subject: [PATCH 2/3] linter --- sklbench/utils/common.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/sklbench/utils/common.py b/sklbench/utils/common.py index 2eca531c..cb45498f 100755 --- a/sklbench/utils/common.py +++ b/sklbench/utils/common.py @@ -66,7 +66,11 @@ def read_output_from_command(command: str) -> Tuple[int, str, str]: stderr=sp.PIPE, encoding="utf-8", ) - return res.returncode, res.stdout.strip(), res.stderr.strip() + return ( + res.returncode, + res.stdout.strip(), + res.stderr.strip(), + ) def hash_from_json_repr(x: JsonTypesUnion, hash_limit: int = 5) -> str: From 9e335bcc0ff7de29f61391dfe5d38159c23a1cff Mon Sep 17 00:00:00 2001 From: Alexander Andreev Date: Fri, 28 Feb 2025 16:17:13 +0000 Subject: [PATCH 3/3] Linting --- sklbench/utils/common.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sklbench/utils/common.py b/sklbench/utils/common.py index cb45498f..4686d6b3 100755 --- a/sklbench/utils/common.py +++ b/sklbench/utils/common.py @@ -124,7 +124,7 @@ def flatten_list(input_list: List, ensure_type_homogeneity: bool = False) -> Lis def get_module_members( - module_names_chain: Union[List, str] + module_names_chain: Union[List, str], ) -> Tuple[ModuleContentMap, ModuleContentMap]: def get_module_name(module_names_chain: List[str]) -> str: name = module_names_chain[0]