address comments

Author: vtavana

dpnp/dpnp_iface_mathematical.py

@@ -321,6 +321,7 @@ def angle(z, deg=False):
     See Also
     --------
     :obj:`dpnp.arctan2` : Element-wise arc tangent of `x1/x2` choosing the quadrant correctly.
+    :obj:`dpnp.arctan` : Trigonometric inverse tangent, element-wise.
     :obj:`dpnp.absolute` : Calculate the absolute value element-wise.
 
     Examples
@@ -335,18 +336,11 @@ def angle(z, deg=False):
 
     """
 
-    if not dpnp.isscalar(z):
-        dpnp.check_supported_arrays_type(z)
-        res = dpnp_angle(z)
-        if deg is True:
-            res = res * (180 / dpnp.pi)
-        return res
-    else:
-        return call_origin(
-            numpy.angle,
-            z,
-            deg=deg,
-        )
+    dpnp.check_supported_arrays_type(z)
+    res = dpnp_angle(z)
+    if deg is True:
+        res = res * (180 / dpnp.pi)
+    return res
 
 
 def around(x, /, decimals=0, out=None):
@@ -1536,21 +1530,23 @@ def gradient(x1, *varargs, **kwargs):
     return call_origin(numpy.gradient, x1, *varargs, **kwargs)
 
 
-def imag(x):
+def imag(val):
     """
     Return the imaginary part of the complex argument.
 
     For full documentation refer to :obj:`numpy.imag`.
 
+    Parameters
+    ----------
+    x : {dpnp.ndarray, usm_ndarray}
+        Input array.
+
     Returns
     -------
     out : dpnp.ndarray
-        The imaginary component of the complex argument.
-
-    Limitations
-    -----------
-    Parameter `x` is only supported as either :class:`dpnp.ndarray` or :class:`dpctl.tensor.usm_ndarray`.
-    Input array data types are limited by supported DPNP :ref:`Data types`.
+        The imaginary component of the complex argument. If `val` is real,
+        the type of `val` is used for the output. If `val` has complex
+        elements, the returned type is float.
 
     See Also
     --------
@@ -1574,12 +1570,8 @@ def imag(x):
 
     """
 
-    if dpnp.isscalar(x):
-        # input has to be an array
-        pass
-    else:
-        return dpnp_imag(x)
-    return call_origin(numpy.imag, x)
+    dpnp.check_supported_arrays_type(val)
+    return dpnp_imag(val)
 
 
 def maximum(
@@ -2268,21 +2260,23 @@ def proj(
     )
 
 
-def real(x):
+def real(val):
     """
     Return the real part of the complex argument.
 
     For full documentation refer to :obj:`numpy.real`.
 
+    Parameters
+    ----------
+    x : {dpnp.ndarray, usm_ndarray}
+        Input array.
+
     Returns
     -------
     out : dpnp.ndarray
-        The real component of the complex argument.
-
-    Limitations
-    -----------
-    Parameter `x` is only supported as either :class:`dpnp.ndarray` or :class:`dpctl.tensor.usm_ndarray`.
-    Input array data types are limited by supported DPNP :ref:`Data types`.
+        The real component of the complex argument.  If `val` is real,
+        the type of `val` is used for the output. If `val` has complex
+        elements, the returned type is float.
 
     See Also
     --------
@@ -2309,15 +2303,12 @@ def real(x):
     array(1.)
 
     """
-    if dpnp.isscalar(x):
-        # input has to be an array
-        pass
+
+    dpnp.check_supported_arrays_type(val)
+    if dpnp.issubsctype(val.dtype, dpnp.complexfloating):
+        return dpnp_real(val)
     else:
-        if dpnp.issubsctype(x.dtype, dpnp.complexfloating):
-            return dpnp_real(x)
-        else:
-            return x
-    return call_origin(numpy.real, x)
+        return val
 
 
 def remainder(

dpnp/dpnp_iface_trigonometric.py

@@ -1452,6 +1452,10 @@ def reciprocal(
     Keyword argument `kwargs` is currently unsupported.
     Otherwise the function will be executed sequentially on CPU.
 
+    See Also
+    --------
+    :obj:`dpnp.rsqrt` : Return the reciprocal square-root of an array, element-wise.
+
     Examples
     --------
     >>> import dpnp as np

tests/test_umath.py

@@ -85,7 +85,7 @@ def test_umaths(test_cases):
     args = get_args(args_str, sh, xp=numpy)
     iargs = get_args(args_str, sh, xp=dpnp)
 
-    if umath == "reciprocal" and iargs[0].dtype in [dpnp.int32, dpnp.int64]:
+    if umath == "reciprocal" and args[0].dtype in [numpy.int32, numpy.int64]:
         pytest.skip("For integer input array, numpy.reciprocal returns zero.")
 
     # original

tests/third_party/cupy/math_tests/test_arithmetic.py

@@ -83,7 +83,6 @@ def test_raises_with_numpy_input(self):
                         testing.shaped_arange((2, 3), numpy, dtype=d)
                         for d in all_types
                     ]
-                    + [0, 0.0j, 0j, 2, 2.0, 2j, True, False]
                 ),
                 "name": ["conj", "conjugate", "real", "imag"],
             }
@@ -95,7 +94,6 @@ def test_raises_with_numpy_input(self):
                         testing.shaped_arange((2, 3), numpy, dtype=d)
                         for d in all_types
                     ]
-                    + [0, 0.0j, 0j, 2, 2.0, 2j, True, False]
                 ),
                 "deg": [True, False],
                 "name": ["angle"],
@@ -108,7 +106,6 @@ def test_raises_with_numpy_input(self):
                         numpy.array([-3, -2, -1, 1, 2, 3], dtype=d)
                         for d in negative_types_wo_fp16
                     ]
-                    + [0, 0.0j, 0j, 2, 2.0, 2j, -2, -2.0, -2j, True, False]
                 ),
                 "deg": [True, False],
                 "name": ["angle"],
@@ -121,14 +118,12 @@ def test_raises_with_numpy_input(self):
                         testing.shaped_arange((2, 3), numpy, dtype=d) + 1
                         for d in all_types
                     ]
-                    + [2, 2.0]
                 ),
                 "name": ["reciprocal"],
             }
         )
     )
 )
-@pytest.mark.usefixtures("allow_fall_back_on_numpy")
 class TestArithmeticUnary:
     @testing.numpy_cupy_allclose(atol=1e-5, type_check=has_support_aspect64())
     def test_unary(self, xp):