Skip to content

Commit 8ad2252

Browse files
committed
address comments
1 parent 75975c0 commit 8ad2252

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

dpnp/tests/helper.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,9 @@ def generate_random_numpy_array(
203203
204204
"""
205205

206-
numpy.random.seed(seed_value) if seed_value else numpy.random.seed(42)
206+
if seed_value is None:
207+
seed_value = 42
208+
numpy.random.seed(seed_value)
207209

208210
# dtype=int is needed for 0d arrays
209211
size = numpy.prod(shape, dtype=int)

dpnp/tests/test_linalg.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1815,7 +1815,7 @@ def test_lstsq(self, a_shape, b_shape, dtype):
18151815
for param_dp, param_np in zip(result, expected):
18161816
assert_dtype_allclose(param_dp, param_np)
18171817

1818-
@pytest.mark.parametrize("a_dtype", get_all_dtypes())
1818+
@pytest.mark.parametrize("a_dtype", get_all_dtypes(no_none=True))
18191819
@pytest.mark.parametrize("b_dtype", get_all_dtypes())
18201820
def test_lstsq_diff_type(self, a_dtype, b_dtype):
18211821
a_np = generate_random_numpy_array((2, 2), a_dtype)

0 commit comments

Comments
 (0)