Skip to content

Commit 28f4fe9

Browse files
committed
add new tests to improve coverage
1 parent f89b813 commit 28f4fe9

File tree

1 file changed

+30
-12
lines changed

1 file changed

+30
-12
lines changed

tests/test_statistics.py

Lines changed: 30 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import dpctl.tensor as dpt
12
import numpy
23
import pytest
34
from numpy.testing import assert_allclose
@@ -61,27 +62,44 @@ def test_max_min_bool(axis, keepdims):
6162
assert_allclose(dpnp_res, np_res)
6263

6364

64-
@pytest.mark.parametrize("axis", [None, 0, 1, -1, 2, -2, (1, 2), (0, -2)])
65-
@pytest.mark.parametrize("keepdims", [False, True])
66-
@pytest.mark.parametrize("dtype", get_all_dtypes(no_bool=True))
67-
def test_max_min_out(axis, keepdims, dtype):
68-
a = numpy.arange(768, dtype=dtype).reshape((4, 4, 6, 8))
65+
def test_max_min_out():
66+
a = numpy.arange(6).reshape((2, 3))
6967
ia = dpnp.array(a)
7068

71-
np_res = numpy.max(a, axis=axis, keepdims=keepdims)
69+
np_res = numpy.max(a, axis=0)
7270
dpnp_res = dpnp.array(numpy.empty_like(np_res))
73-
dpnp.max(ia, axis=axis, keepdims=keepdims, out=dpnp_res)
71+
dpnp.max(ia, axis=0, out=dpnp_res)
72+
assert_allclose(dpnp_res, np_res)
7473

75-
assert dpnp_res.shape == np_res.shape
74+
dpnp_res = dpt.asarray(numpy.empty_like(np_res))
75+
dpnp.max(ia, axis=0, out=dpnp_res)
7676
assert_allclose(dpnp_res, np_res)
7777

78-
np_res = numpy.min(a, axis=axis, keepdims=keepdims)
78+
dpnp_res = numpy.empty_like(np_res)
79+
with pytest.raises(TypeError):
80+
dpnp.max(ia, axis=0, out=dpnp_res)
81+
82+
dpnp_res = dpnp.array(numpy.empty((2, 3)))
83+
with pytest.raises(ValueError):
84+
dpnp.max(ia, axis=0, out=dpnp_res)
85+
86+
np_res = numpy.min(a, axis=0)
7987
dpnp_res = dpnp.array(numpy.empty_like(np_res))
80-
dpnp.min(ia, axis=axis, keepdims=keepdims, out=dpnp_res)
88+
dpnp.min(ia, axis=0, out=dpnp_res)
89+
assert_allclose(dpnp_res, np_res)
8190

82-
assert dpnp_res.shape == np_res.shape
91+
dpnp_res = dpt.asarray(numpy.empty_like(np_res))
92+
dpnp.min(ia, axis=0, out=dpnp_res)
8393
assert_allclose(dpnp_res, np_res)
8494

95+
dpnp_res = numpy.empty_like(np_res)
96+
with pytest.raises(TypeError):
97+
dpnp.min(ia, axis=0, out=dpnp_res)
98+
99+
dpnp_res = dpnp.array(numpy.empty((2, 3)))
100+
with pytest.raises(ValueError):
101+
dpnp.min(ia, axis=0, out=dpnp_res)
102+
85103

86104
def test_max_min_NotImplemented():
87105
ia = dpnp.arange(5)
@@ -94,7 +112,7 @@ def test_max_min_NotImplemented():
94112
with pytest.raises(NotImplementedError):
95113
dpnp.min(ia, where=False)
96114
with pytest.raises(NotImplementedError):
97-
dpnp.max(ia, initial=6)
115+
dpnp.min(ia, initial=6)
98116

99117

100118
@pytest.mark.usefixtures("allow_fall_back_on_numpy")

0 commit comments

Comments
 (0)