Skip to content

Commit ea6dd27

Browse files
Fixes per PR review feedback
1. Aligned default values with those of np.allclose 2. Replaced less test with less_equal to align with NumPy.
1 parent d60d58e commit ea6dd27

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

dpctl/tensor/_testing.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ def _allclose_complex_fp(z1, z2, atol, rtol, equal_nan):
6464
mv2 = z2i[mi]
6565
check5 = dpt.all(
6666
dpt.abs(mv1 - mv2)
67-
< atol + rtol * dpt.maximum(dpt.abs(mv1), dpt.abs(mv2))
67+
<= atol + rtol * dpt.maximum(dpt.abs(mv1), dpt.abs(mv2))
6868
)
6969
return check5
7070

@@ -90,7 +90,7 @@ def _allclose_real_fp(r1, r2, atol, rtol, equal_nan):
9090
mv2 = r2[m]
9191
check4 = dpt.all(
9292
dpt.abs(mv1 - mv2)
93-
< atol + rtol * dpt.maximum(dpt.abs(mv1), dpt.abs(mv2))
93+
<= atol + rtol * dpt.maximum(dpt.abs(mv1), dpt.abs(mv2))
9494
)
9595
return check4
9696

@@ -99,10 +99,10 @@ def _allclose_others(r1, r2):
9999
return dpt.all(r1 == r2)
100100

101101

102-
def allclose(a1, a2, atol=1e-5, rtol=1e-8, equal_nan=False):
103-
"""allclose(a1, a2, atol=1e-5, rtol=1e-8)
102+
def allclose(a1, a2, atol=1e-8, rtol=1e-5, equal_nan=False):
103+
"""allclose(a1, a2, atol=1e-8, rtol=1e-5, equal_nan=False)
104104
105-
Returns True if two arrays are element-wise equal within tolerance.
105+
Returns True if two arrays are element-wise equal within tolerances.
106106
"""
107107
if not isinstance(a1, dpt.usm_ndarray):
108108
raise TypeError(

0 commit comments

Comments
 (0)