Fix Cython warning caused by cimporting from Numpy

ndgrigorian · ndgrigorian · commit d326314923ee · 2024-08-02T14:43:00.000-07:00
When using cimport with Numpy, a warning for a deprecated C-API is thrown

NPY_NO_DEPRECATED_API=NPY_1_7_API_VERSION is now defined for targets in `build_dpctl_ext` to address this warning
diff --git a/dpctl/CMakeLists.txt b/dpctl/CMakeLists.txt
@@ -125,6 +125,8 @@ function(build_dpctl_ext _trgt _src _dest)
             )
         endif()
     endif()
+    # needed to prevent warnings from Cython caused by cimporting from Numpy
+    target_compile_definitions(${_trgt} PRIVATE NPY_NO_DEPRECATED_API=NPY_1_7_API_VERSION)
     target_link_libraries(${_trgt} PRIVATE Python::NumPy)
     if (DPCTL_GENERATE_COVERAGE)
         target_compile_definitions(${_trgt} PRIVATE CYTHON_TRACE=1 CYTHON_TRACE_NOGIL=1)

Original file line number	Diff line number	Diff line change
`@@ -125,6 +125,8 @@ function(build_dpctl_ext _trgt _src _dest)`
`125`	`125`	`)`
`126`	`126`	`endif()`
`127`	`127`	`endif()`
	`128`	`+ # needed to prevent warnings from Cython caused by cimporting from Numpy`
	`129`	`+ target_compile_definitions(${_trgt} PRIVATE NPY_NO_DEPRECATED_API=NPY_1_7_API_VERSION)`
`128`	`130`	`target_link_libraries(${_trgt} PRIVATE Python::NumPy)`
`129`	`131`	`if (DPCTL_GENERATE_COVERAGE)`
`130`	`132`	`target_compile_definitions(${_trgt} PRIVATE CYTHON_TRACE=1 CYTHON_TRACE_NOGIL=1)`