Skip to content

Commit b88f8ee

Browse files
Relaxed tolerance for cumultivae_logsumexp closed form test
Made failure more informative
1 parent 3395d05 commit b88f8ee

File tree

1 file changed

+9
-2
lines changed

1 file changed

+9
-2
lines changed

dpctl/tests/test_tensor_accumulation.py

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -408,5 +408,12 @@ def test_cumulative_logsumexp_closed_form(fpdt):
408408
r = dpt.cumulative_logsumexp(dpt.arange(-n, 0, dtype=fpdt, device=q))
409409
expected = geometric_series_closed_form(n, dtype=fpdt, device=q)
410410

411-
tol = 4 * dpt.finfo(fpdt).eps
412-
assert dpt.allclose(r, expected, atol=tol, rtol=tol)
411+
tol = 32 * dpt.finfo(fpdt).eps
412+
if not dpt.allclose(r, expected, atol=tol, rtol=tol):
413+
ad = dpt.abs(r - expected)
414+
max = dpt.max(ad)
415+
viols = ad > tol + tol * dpt.maximum(dpt.abs(r), dpt.abs(expected))
416+
viols_count = dpt.sum(viols)
417+
assert (
418+
False
419+
), f"allclose failed, absdiff = {max}, violations = {viols_count}"

0 commit comments

Comments
 (0)