Skip to content

Commit 6bde41f

Browse files
committed
Apply suggestions from code review
Apply review suggestions
1 parent d9dab91 commit 6bde41f

File tree

2 files changed

+12
-14
lines changed

2 files changed

+12
-14
lines changed

dpctl/tensor/_statistical_functions.py

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -141,15 +141,8 @@ def _var_impl(x, axis, correction, keepdims):
141141
res_shape = res.shape
142142
# when nelems - correction <= 0, yield nans
143143
div = max(nelems - correction, 0)
144-
if div:
145-
dep_evs = _manager.submitted_events
146-
ht_e7, d_e2 = tei._divide_by_scalar(
147-
src=res, scalar=div, dst=res, sycl_queue=q, depends=dep_evs
148-
)
149-
_manager.add_event_pair(ht_e7, d_e2)
150-
return res, [d_e2]
151-
152-
div = dpt.nan
144+
if not div:
145+
div = dpt.nan
153146
dep_evs = _manager.submitted_events
154147
ht_e7, d_e2 = tei._divide_by_scalar(
155148
src=res, scalar=div, dst=res, sycl_queue=q, depends=dep_evs

dpctl/tensor/libtensor/source/elementwise_functions/true_divide.cpp

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -313,27 +313,32 @@ py_divide_by_scalar(const dpctl::tensor::usm_ndarray &src,
313313
fn = divide_by_scalar<sycl::half, sycl::half>;
314314
std::ignore =
315315
new (scalar_alloc) sycl::half(static_cast<sycl::half>(scalar));
316-
} break;
316+
break;
317+
}
317318
case float32_typeid:
318319
{
319320
fn = divide_by_scalar<float, float>;
320321
std::ignore = new (scalar_alloc) float(scalar);
321-
} break;
322+
break;
323+
}
322324
case float64_typeid:
323325
{
324326
fn = divide_by_scalar<double, double>;
325327
std::ignore = new (scalar_alloc) double(scalar);
326-
} break;
328+
break;
329+
}
327330
case complex64_typeid:
328331
{
329332
fn = divide_by_scalar<std::complex<float>, float>;
330333
std::ignore = new (scalar_alloc) float(scalar);
331-
} break;
334+
break;
335+
}
332336
case complex128_typeid:
333337
{
334338
fn = divide_by_scalar<std::complex<double>, double>;
335339
std::ignore = new (scalar_alloc) double(scalar);
336-
} break;
340+
break;
341+
}
337342
default:
338343
throw std::runtime_error("Implementation is missing for typeid=" +
339344
std::to_string(src_typeid));

0 commit comments

Comments
 (0)