Skip to content

Commit 65230a4

Browse files
Further streamlining usm_memory constructor
1 parent 1ef63da commit 65230a4

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

dpctl/apis/include/dpctl4pybind11.hpp

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -764,7 +764,7 @@ class usm_memory : public py::object
764764
reinterpret_cast<DPCTLSyclQueueRef>(q_uptr.get());
765765

766766
auto vacuous_destructor = []() {};
767-
py::object mock_owner = py::capsule(vacuous_destructor);
767+
py::capsule mock_owner(vacuous_destructor);
768768

769769
// create memory object owned by mock_owner, it is a new reference
770770
PyObject *_memory =
@@ -773,14 +773,13 @@ class usm_memory : public py::object
773773

774774
using py_uptrT =
775775
std::unique_ptr<PyObject, decltype(ref_count_decrementer)>;
776-
auto memory_uptr = py_uptrT(_memory, ref_count_decrementer);
777776

778777
if (!_memory) {
779778
throw py::error_already_set();
780779
}
781780

782-
std::shared_ptr<void> *opaque_ptr = nullptr;
783-
opaque_ptr = new std::shared_ptr<void>(shptr);
781+
auto memory_uptr = py_uptrT(_memory, ref_count_decrementer);
782+
std::shared_ptr<void> *opaque_ptr = new std::shared_ptr<void>(shptr);
784783

785784
Py_MemoryObject *memobj = reinterpret_cast<Py_MemoryObject *>(_memory);
786785
// replace mock_owner capsule as the owner

0 commit comments

Comments
 (0)