Skip to content

Commit 5f3b774

Browse files
committed
Refactor cmake for setting AMD targets and fix incorrect logic
1 parent 8bb2136 commit 5f3b774

File tree

1 file changed

+7
-9
lines changed

1 file changed

+7
-9
lines changed

CMakeLists.txt

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ option(DPCTL_TARGET_CUDA
3131
)
3232
set(DPCTL_TARGET_AMD
3333
""
34-
CACHE STRING
34+
CACHE STRING
3535
"Build DPCTL to target an AMD device architecture"
3636
)
3737
option(DPCTL_WITH_REDIST "Build DPCTL assuming DPC++ redistributable is installed into Python prefix" OFF)
@@ -52,21 +52,19 @@ if ("x${DPCTL_SYCL_TARGETS}" STREQUAL "x")
5252
endif()
5353
endif()
5454
if (NOT "x${DPCTL_TARGET_AMD}" STREQUAL "x")
55+
set(_dpctl_amd_targets ${DPCTL_TARGET_AMD})
5556
if(_dpctl_sycl_targets)
56-
set(_dpctl_sycl_targets "amdgcn-amd-amdhsa,spir64-unknown-unknown")
57-
set(_dpctl_amd_targets ${DPCTL_TARGET_AMD})
58-
else()
5957
set(_dpctl_sycl_targets "amdgcn-amd-amdhsa,${_dpctl_sycl_targets}")
60-
set(_dpctl_amd_targets ${DPCTL_TARGET_AMD})
58+
else()
59+
set(_dpctl_sycl_targets "amdgcn-amd-amdhsa,spir64-unknown-unknown")
6160
endif()
6261
else()
6362
if (DEFINED ENV{DPCTL_TARGET_AMD})
63+
set(_dpctl_amd_targets $ENV{DPCTL_TARGET_AMD})
6464
if(_dpctl_sycl_targets)
65-
set(_dpctl_sycl_targets "amdgcn-amd-amdhsa,spir64-unknown-unknown")
66-
set(_dpctl_amd_targets $ENV{DPCTL_TARGET_AMD})
67-
else()
6865
set(_dpctl_sycl_targets "amdgcn-amd-amdhsa,${_dpctl_sycl_targets}")
69-
set(_dpctl_amd_targets $ENV{DPCTL_TARGET_AMD})
66+
else()
67+
set(_dpctl_sycl_targets "amdgcn-amd-amdhsa,spir64-unknown-unknown")
7068
endif()
7169
endif()
7270
endif()

0 commit comments

Comments
 (0)