Skip to content

Commit 9897255

Browse files
committed
prepare public api extension visibility reduce for "TranslatorProvider"
1 parent 2cd20a0 commit 9897255

File tree

3 files changed

+16
-8
lines changed

3 files changed

+16
-8
lines changed

src/main/java/fr/adrienbrault/idea/symfony2plugin/translation/dict/TranslationUtil.java

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,9 @@
2121
import fr.adrienbrault.idea.symfony2plugin.translation.TranslatorLookupElement;
2222
import fr.adrienbrault.idea.symfony2plugin.translation.collector.YamlTranslationVisitor;
2323
import fr.adrienbrault.idea.symfony2plugin.translation.parser.DomainMappings;
24+
import fr.adrienbrault.idea.symfony2plugin.translation.provider.CompiledContainerTranslatorProvider;
25+
import fr.adrienbrault.idea.symfony2plugin.translation.provider.CompiledTranslatorProvider;
26+
import fr.adrienbrault.idea.symfony2plugin.translation.provider.IndexTranslatorProvider;
2427
import fr.adrienbrault.idea.symfony2plugin.util.MethodMatcher;
2528
import fr.adrienbrault.idea.symfony2plugin.util.PhpElementsUtil;
2629
import fr.adrienbrault.idea.symfony2plugin.util.PsiElementUtils;
@@ -46,12 +49,18 @@
4649
import java.util.regex.Matcher;
4750
import java.util.regex.Pattern;
4851
import java.util.stream.Collectors;
52+
import java.util.stream.Stream;
4953

5054
/**
5155
* @author Daniel Espendiller <daniel@espendiller.net>
5256
*/
5357
public class TranslationUtil {
54-
public static final ExtensionPointName<TranslatorProvider> TRANSLATION_PROVIDER = new ExtensionPointName<>("fr.adrienbrault.idea.symfony2plugin.extension.TranslatorProvider");
58+
private static final ExtensionPointName<TranslatorProvider> TRANSLATION_PROVIDER = new ExtensionPointName<>("fr.adrienbrault.idea.symfony2plugin.extension.TranslatorProvider");
59+
public static final TranslatorProvider[] INTERNAL_TRANSLATOR_PROVIDERS = new TranslatorProvider[]{
60+
new CompiledContainerTranslatorProvider(),
61+
new CompiledTranslatorProvider(),
62+
new IndexTranslatorProvider(),
63+
};
5564

5665
public static MethodMatcher.CallToSignature[] PHP_TRANSLATION_SIGNATURES = new MethodMatcher.CallToSignature[] {
5766
new MethodMatcher.CallToSignature("\\Symfony\\Component\\Translation\\TranslatorInterface", "trans"),
@@ -378,8 +387,12 @@ public static Set<String> getPlaceholderFromTranslation(@NotNull String text) {
378387
return placeholder;
379388
}
380389

390+
@NotNull
381391
private static TranslatorProvider[] getTranslationProviders() {
382-
return TRANSLATION_PROVIDER.getExtensions();
392+
return Stream.concat(
393+
Arrays.stream(INTERNAL_TRANSLATOR_PROVIDERS),
394+
Arrays.stream(TRANSLATION_PROVIDER.getExtensions())
395+
).toArray(TranslatorProvider[]::new);
383396
}
384397

385398
/**

src/main/resources/META-INF/pay.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<extensionPoints>
55
<extensionPoint dynamic="true" name="extension.PluginConfigurationExtension" interface="fr.adrienbrault.idea.symfony2plugin.extension.PluginConfigurationExtension"/>
66
<extensionPoint dynamic="true" name="extension.TwigFileUsage" interface="fr.adrienbrault.idea.symfony2plugin.extension.TwigFileUsage"/>
7-
7+
<extensionPoint dynamic="true" name="extension.TranslatorProvider" interface="fr.adrienbrault.idea.symfony2plugin.extension.TranslatorProvider"/>
88

99
</extensionPoints>
1010

src/main/resources/META-INF/plugin.xml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -563,7 +563,6 @@
563563
<extensionPoint dynamic="true" name="extension.ServiceParameterCollector" interface="fr.adrienbrault.idea.symfony2plugin.extension.ServiceParameterCollector"/>
564564
<extensionPoint dynamic="true" name="extension.ServiceDefinitionLocator" interface="fr.adrienbrault.idea.symfony2plugin.extension.ServiceDefinitionLocator"/>
565565
<extensionPoint dynamic="true" name="extension.TwigVariableCollector" interface="fr.adrienbrault.idea.symfony2plugin.templating.variable.TwigFileVariableCollector"/>
566-
<extensionPoint dynamic="true" name="extension.TranslatorProvider" interface="fr.adrienbrault.idea.symfony2plugin.extension.TranslatorProvider"/>
567566
</extensionPoints>
568567

569568
<extensions defaultExtensionNs="fr.adrienbrault.idea.symfony2plugin.extension">
@@ -618,10 +617,6 @@
618617
<TwigVariableCollector implementation="fr.adrienbrault.idea.symfony2plugin.templating.variable.collector.IncludeVariableCollector"/>
619618
<TwigVariableCollector implementation="fr.adrienbrault.idea.symfony2plugin.templating.variable.collector.MarcoScopeVariableCollector"/>
620619
<TwigVariableCollector implementation="fr.adrienbrault.idea.symfony2plugin.twig.variable.collector.GlobalTwigConfigVariableCollector"/>
621-
622-
<TranslatorProvider implementation="fr.adrienbrault.idea.symfony2plugin.translation.provider.CompiledTranslatorProvider"/>
623-
<TranslatorProvider implementation="fr.adrienbrault.idea.symfony2plugin.translation.provider.IndexTranslatorProvider"/>
624-
<TranslatorProvider implementation="fr.adrienbrault.idea.symfony2plugin.translation.provider.CompiledContainerTranslatorProvider"/>
625620
</extensions>
626621

627622
<depends>com.jetbrains.twig</depends>

0 commit comments

Comments
 (0)