#1984 support parameters inside "Autowire" attribute

Author: Haehnchen

src/main/java/fr/adrienbrault/idea/symfony2plugin/dic/registrar/DicGotoCompletionRegistrar.java

@@ -3,6 +3,10 @@
 import com.intellij.codeInsight.lookup.LookupElement;
 import com.intellij.patterns.PlatformPatterns;
 import com.intellij.psi.PsiElement;
+import com.intellij.psi.util.PsiTreeUtil;
+import com.jetbrains.php.lang.lexer.PhpTokenTypes;
+import com.jetbrains.php.lang.psi.elements.ParameterList;
+import com.jetbrains.php.lang.psi.elements.PhpAttribute;
 import com.jetbrains.php.lang.psi.elements.StringLiteralExpression;
 import fr.adrienbrault.idea.symfony2plugin.codeInsight.GotoCompletionProvider;
 import fr.adrienbrault.idea.symfony2plugin.codeInsight.GotoCompletionRegistrar;
@@ -26,6 +30,8 @@
  */
 public class DicGotoCompletionRegistrar implements GotoCompletionRegistrar {
 
+    public static final String AUTOWIRE_ATTRIBUTE_CLASS = "\\Symfony\\Component\\DependencyInjection\\Attribute\\Autowire";
+
     @Override
     public void register(@NotNull GotoCompletionRegistrarParameter registrar) {
         // getParameter('FOO')
@@ -65,6 +71,40 @@ public void register(@NotNull GotoCompletionRegistrarParameter registrar) {
                 return new ParameterContributor((StringLiteralExpression) context);
             }
         );
+
+        // #[Autowire('<caret>')]
+        registrar.register(
+            PlatformPatterns.psiElement(), psiElement -> {
+                PsiElement context = psiElement.getContext();
+                if (!(context instanceof StringLiteralExpression)) {
+                    return null;
+                }
+
+                PsiElement prevSibling = context.getPrevSibling();
+                if (prevSibling == null) {
+                    PsiElement parent = context.getParent();
+                    if (parent instanceof ParameterList) {
+                        PsiElement parent2 = parent.getParent();
+                        if (parent2 instanceof PhpAttribute) {
+                            String fqn = ((PhpAttribute) parent2).getFQN();
+                            if (fqn != null && PhpElementsUtil.isInstanceOf(psiElement.getProject(), fqn, AUTOWIRE_ATTRIBUTE_CLASS)) {
+                                return new ParameterContributor((StringLiteralExpression) context);
+                            }
+                        }
+                    }
+                } else {
+                    PsiElement psiElement1 = PsiTreeUtil.prevVisibleLeaf(prevSibling);
+                    if (psiElement1 != null && psiElement1.getNode().getElementType() == PhpTokenTypes.opCOLON) {
+                        PsiElement psiElement2 = PsiTreeUtil.prevVisibleLeaf(psiElement1);
+                        if (psiElement2 != null && psiElement2.getNode().getElementType() == PhpTokenTypes.IDENTIFIER && "value".equals(psiElement2.getText())) {
+                            return new ParameterContributor((StringLiteralExpression) context);
+                        }
+                    }
+                }
+
+                return null;
+            }
+        );
     }
 
     private static class ParameterContributor extends GotoCompletionProvider {

src/test/java/fr/adrienbrault/idea/symfony2plugin/tests/dic/registrar/DicGotoCompletionRegistrarTest.java

@@ -63,4 +63,60 @@ public void testParameterContributorFor() {
             PlatformPatterns.psiElement()
         );
     }
+
+    public void testParameterContributorForDefaultAttribute() {
+        assertCompletionContains(PhpFileType.INSTANCE, "<?php\n" +
+                "use Symfony\\Component\\DependencyInjection\\Attribute\\Autowire;\n" +
+                "\n" +
+                "class MyService\n" +
+                "{\n" +
+                "    public function __construct(\n" +
+                "        #[Autowire('<caret>')]\n" +
+                "        private $parameter2" +
+                "    ) {}\n" +
+                "}",
+            "foo"
+        );
+
+        assertNavigationMatch(PhpFileType.INSTANCE, "<?php\n" +
+                "use Symfony\\Component\\DependencyInjection\\Attribute\\Autowire;\n" +
+                "\n" +
+                "class MyService\n" +
+                "{\n" +
+                "    public function __construct(\n" +
+                "        #[Autowire('fo<caret>o')]\n" +
+                "        private $parameter2" +
+                "    ) {}\n" +
+                "}",
+            PlatformPatterns.psiElement()
+        );
+    }
+
+    public void testParameterContributorForNamedAttribute() {
+        assertCompletionContains(PhpFileType.INSTANCE, "<?php\n" +
+                "use Symfony\\Component\\DependencyInjection\\Attribute\\Autowire;\n" +
+                "\n" +
+                "class MyService\n" +
+                "{\n" +
+                "    public function __construct(\n" +
+                "        #[Autowire(value: '<caret>')]\n" +
+                "        private $parameter2" +
+                "    ) {}\n" +
+                "}",
+            "foo"
+        );
+
+        assertNavigationMatch(PhpFileType.INSTANCE, "<?php\n" +
+                "use Symfony\\Component\\DependencyInjection\\Attribute\\Autowire;\n" +
+                "\n" +
+                "class MyService\n" +
+                "{\n" +
+                "    public function __construct(\n" +
+                "        #[Autowire(value: 'fo<caret>o')]\n" +
+                "        private $parameter2" +
+                "    ) {}\n" +
+                "}",
+            PlatformPatterns.psiElement()
+        );
+    }
 }

src/test/java/fr/adrienbrault/idea/symfony2plugin/tests/dic/registrar/fixtures/classes.php

@@ -9,6 +9,23 @@ function hasParameter($parameter);
     }
 }
 
+namespace Symfony\Component\DependencyInjection\Attribute
+{
+    class Autowire
+    {
+        /**
+         * @param string|null $value      Parameter value (ie "%kernel.project_dir%/some/path")
+         * @param string|null $service    Service ID (ie "some.service")
+         * @param string|null $expression Expression (ie 'service("some.service").someMethod()')
+         */
+        public function __construct(
+            string $value = null,
+            string $service = null,
+            string $expression = null,
+        ) {}
+    }
+}
+
 namespace
 {
     class Foo