fix: Don't assume crates are non-breaking just because they are in the user selection. (#422)

Crates shownig up 'early' in our list could cause the entire
breakage-propagation to fail which led the crate to be ignored entirely
even when their dependees changed their version. This led to
inconsistent version requirements which would abort any cargo call.

Fixes #422.

Author: Byron

cargo-smart-release/src/traverse.rs

@@ -270,14 +270,18 @@ fn forward_propagate_breaking_changes_for_manifest_updates<'meta>(
                     continue;
                 }
                 seen.insert(&dependant.id);
-                let crate_is_known_already = crates.iter().find_map(|c| {
-                    (c.package.id == dependant.id).then(|| c.mode.version_adjustment_bump().map(|b| b.is_breaking()))
-                });
+                let crate_is_known_already = crates
+                    .iter()
+                    .find_map(|c| {
+                        (c.package.id == dependant.id)
+                            .then(|| c.mode.version_adjustment_bump().map(|b| b.is_breaking()))
+                    })
+                    .flatten();
 
                 let bump = breaking_version_bump(ctx, dependant, bump_when_needed)?;
                 if bump.next_release_changes_manifest() {
                     if crate_is_known_already.is_some() {
-                        let is_breaking = crate_is_known_already.flatten().unwrap_or(false);
+                        let is_breaking = crate_is_known_already.unwrap_or(false);
                         if !is_breaking {
                             log::debug!(
                                 "Wanted to mark '{}' for breaking manifest change, but its already known without breaking change.",