change!: re-export the entire date crate instead of its individual types.

Author: Byron

gix-actor/src/lib.rs

@@ -9,8 +9,16 @@
 #![deny(missing_docs, rust_2018_idioms)]
 #![forbid(unsafe_code)]
 
+/// The re-exported `bstr` crate.
+///
+/// For convenience to allow using `bstr` without adding it to own cargo manifest.
+pub use bstr;
 use bstr::{BStr, BString};
-pub use gix_date::{time::Sign, Time};
+/// The re-exported `gix-date` crate.
+///
+/// For convenience to allow using `gix-date` without adding it to own cargo manifest.
+pub use gix_date as date;
+use gix_date::Time;
 
 mod identity;
 ///

gix-actor/src/signature/decode.rs

@@ -1,7 +1,8 @@
 pub(crate) mod function {
     use bstr::ByteSlice;
     use btoi::btoi;
-    use gix_date::{OffsetInSeconds, SecondsSinceUnixEpoch};
+    use gix_date::time::Sign;
+    use gix_date::{OffsetInSeconds, SecondsSinceUnixEpoch, Time};
     use nom::{
         branch::alt,
         bytes::complete::{tag, take, take_until, take_while_m_n},
@@ -11,7 +12,7 @@ pub(crate) mod function {
         IResult,
     };
 
-    use crate::{IdentityRef, Sign, SignatureRef, Time};
+    use crate::{IdentityRef, SignatureRef};
 
     const SPACE: &[u8] = b" ";
 
@@ -60,7 +61,7 @@ pub(crate) mod function {
                 email: identity.email,
                 time: Time {
                     seconds: time,
-                    offset: offset,
+                    offset,
                     sign,
                 },
             },
@@ -94,11 +95,12 @@ pub use function::identity;
 mod tests {
     mod parse_signature {
         use bstr::ByteSlice;
+        use gix_date::time::Sign;
         use gix_date::{OffsetInSeconds, SecondsSinceUnixEpoch};
         use gix_testtools::to_bstr_err;
         use nom::IResult;
 
-        use crate::{signature, Sign, SignatureRef, Time};
+        use crate::{signature, SignatureRef, Time};
 
         fn decode(i: &[u8]) -> IResult<&[u8], SignatureRef<'_>, nom::error::VerboseError<&[u8]>> {
             signature::decode(i)

gix-actor/tests/signature/mod.rs

@@ -1,6 +1,8 @@
 mod write_to {
     mod invalid {
-        use gix_actor::{Sign, Signature, Time};
+        use gix_actor::Signature;
+        use gix_date::time::Sign;
+        use gix_date::Time;
 
         #[test]
         fn name() {