fix!(gix-actor): Make email with spaces roundtrip

We see this situation in commits in the wild.

Author: pierrechevalier83

gix-actor/src/signature/decode.rs

@@ -79,22 +79,15 @@ pub(crate) mod function {
                 StrContext::Label("Closing '>' not found"),
             )))?;
         let i_name_and_email = &i[..right_delim_idx];
-        let skip_from_right = i_name_and_email
-            .iter()
-            .rev()
-            .take_while(|b| b.is_ascii_whitespace() || **b == b'>')
-            .count();
+        let skip_from_right = i_name_and_email.iter().rev().take_while(|b| **b == b'>').count();
         let left_delim_idx = i_name_and_email
             .find_byte(b'<')
             .ok_or(ErrMode::Cut(E::from_input(i).add_context(
                 &i_name_and_email,
                 &start,
                 StrContext::Label("Opening '<' not found"),
             )))?;
-        let skip_from_left = i[left_delim_idx..]
-            .iter()
-            .take_while(|b| b.is_ascii_whitespace() || **b == b'<')
-            .count();
+        let skip_from_left = i[left_delim_idx..].iter().take_while(|b| **b == b'<').count();
         let mut name = i[..left_delim_idx].as_bstr();
         name = name.strip_suffix(b" ").unwrap_or(name).as_bstr();
 
@@ -164,6 +157,17 @@ mod tests {
             );
         }
 
+        #[test]
+        fn email_with_space() {
+            assert_eq!(
+                decode
+                    .parse_peek(b"Sebastian Thiel <\tbyronimo@gmail.com > 1528473343 +0230")
+                    .expect("parse to work")
+                    .1,
+                signature("Sebastian Thiel", "\tbyronimo@gmail.com ", 1528473343, Sign::Plus, 9000)
+            );
+        }
+
         #[test]
         fn negative_offset_0000() {
             assert_eq!(

gix-actor/tests/identity/mod.rs

@@ -5,6 +5,9 @@ use gix_actor::Identity;
 fn round_trip() -> gix_testtools::Result {
     static DEFAULTS: &[&[u8]] =     &[
         b"Sebastian Thiel <byronimo@gmail.com>",
+        b"Sebastian Thiel < byronimo@gmail.com>",
+        b"Sebastian Thiel <byronimo@gmail.com  >",
+        b"Sebastian Thiel <\tbyronimo@gmail.com \t >",
         ".. ☺️Sebastian 王知明 Thiel🙌 .. <byronimo@gmail.com>".as_bytes(),
         b".. whitespace  \t  is explicitly allowed    - unicode aware trimming must be done elsewhere  <byronimo@gmail.com>"
     ];
@@ -25,10 +28,6 @@ fn lenient_parsing() -> gix_testtools::Result {
     ] {
         let identity = gix_actor::IdentityRef::from_bytes::<()>(input.as_bytes()).unwrap();
         assert_eq!(identity.name, "First Last");
-        assert_eq!(
-            identity.email, "fl <First Last<fl@openoffice.org",
-            "extra trailing and leading angled parens are stripped"
-        );
         let signature: Identity = identity.into();
         let mut output = Vec::new();
         let err = signature.write_to(&mut output).unwrap_err();