Skip to content

Commit ce071bf

Browse files
committed
Clarify commands where we grep for a warning
In this justfile, for the `cargo tree ...| grep warning` commands: - Put the explanatory comment before the first of these commands, rather than at the end of the first one, since this is easier to read in the `just` output, as well as clearer because it applies to a cluster of commands rather than only the first one. This is also more consistent stylistically with other comments in the `justfile`. - Pass `-F` to `grep`, as this is a literal search for the text `warning`. (This is a minor refactoring for clarity, and it may be changed soon if the check is made more precise.)
1 parent aebc335 commit ce071bf

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

justfile

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,10 +50,11 @@ check:
5050
! cargo check -p gix-packetline --all-features 2>/dev/null
5151
! cargo check -p gix-transport --all-features 2>/dev/null
5252
! cargo check -p gix-protocol --all-features 2>/dev/null
53-
cargo tree -p gix --no-default-features -e normal -i imara-diff 2>&1 | grep warning # warning happens if nothing found, no exit code :/
54-
cargo tree -p gix --no-default-features -e normal -i gix-submodule 2>&1 | grep warning
55-
cargo tree -p gix --no-default-features -e normal -i gix-pathspec 2>&1 | grep warning
56-
cargo tree -p gix --no-default-features -e normal -i gix-filter 2>&1 | grep warning
53+
# warning happens if nothing found, no exit code :/
54+
cargo tree -p gix --no-default-features -e normal -i imara-diff 2>&1 | grep -F warning
55+
cargo tree -p gix --no-default-features -e normal -i gix-submodule 2>&1 | grep -F warning
56+
cargo tree -p gix --no-default-features -e normal -i gix-pathspec 2>&1 | grep -F warning
57+
cargo tree -p gix --no-default-features -e normal -i gix-filter 2>&1 | grep -F warning
5758
! cargo tree -p gix --no-default-features -i gix-credentials 2>/dev/null
5859
cargo check --no-default-features --features lean
5960
cargo check --no-default-features --features lean-async

0 commit comments

Comments
 (0)