fix(git-transport): Use single quotes for ssh path arg

Git uses this method of quoting args for SSH transport too
Some Git SSH servers require this method to be used (eg. BitBucket)

Author: exactly-one-kas

git-transport/src/client/blocking_io/file.rs

@@ -191,6 +191,21 @@ fn supervise_stderr(
     ReadStdoutFailOnError { read: stdout, recv }
 }
 
+/// Transforms the given value to be suitable for use as an argument for Bourne shells by wrapping in single quotes
+fn to_single_quoted(mut value: &[u8]) -> Vec<u8> {
+    let mut quoted = b"'".to_vec();
+
+    while let Some(pos) = value.find_byte(b'\'') {
+        quoted.copy_from_slice(&value[..pos]);
+        quoted.copy_from_slice(b"'\\''");
+        value = &value[pos + 1..];
+    }
+
+    quoted.copy_from_slice(value);
+    quoted.push(b'\'');
+    quoted
+}
+
 impl client::Transport for SpawnProcessOnDemand {
     fn handshake<'a>(
         &mut self,
@@ -216,7 +231,8 @@ impl client::Transport for SpawnProcessOnDemand {
         if self.ssh_cmd.is_some() {
             cmd.args.push(service.as_str().into());
         }
-        cmd.args.push(self.path.to_os_str_lossy().into_owned());
+        cmd.args
+            .push(to_single_quoted(self.path.as_ref()).to_os_str_lossy().into_owned());
 
         let mut cmd = std::process::Command::from(cmd);
         for env_to_remove in ENV_VARS_TO_REMOVE {
@@ -282,5 +298,18 @@ mod tests {
                 }
             }
         }
+
+        mod handshake {
+            use crate::client::file::to_single_quoted;
+
+            #[test]
+            fn quoted_strings() {
+                assert_eq!(to_single_quoted(b"my cool string"), b"'my cool string'");
+                assert_eq!(
+                    to_single_quoted(b"\0my `even` ~cooler~ $t\\'ring\\// with \"quotes\""),
+                    b"'\0my `even` ~cooler~ $t\\'\\''ring\\// with \"quotes\"'"
+                );
+            }
+        }
     }
 }