You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
- Use a `bash` array for the long list of crates without feature
toggles, to make clear what crates are covered in this loop, and
so any changes to the list produce clearer diffs, and to improve
the general readability of the workflow.
- In each loop, rename the variable from `name` to `crate`, to make
the meaning clearer. The other significant kind of loop in this
job is over `feature`, so this makes the contrast clear. (Other
loops over array items in other jobs in the workflow, where the
general variable name `name` could be used, already instead use
the more specific variable names `package` and `cmd`.)
This may slightly mitigate #1988 in that it makes it easier for the
big list to be manually inspected, but it does not fix that issue.
0 commit comments