assure that we don't artificially make non-recursable directories visible

A repository may be emitted on its own accord, without having to go through
the folding logic which filters directories that have been 'prefix' matched.

Author: Byron

gix-dir/src/entry.rs

@@ -191,7 +191,7 @@ impl Status {
 }
 
 impl Kind {
-    fn is_recursable_dir(&self) -> bool {
+    pub(super) fn is_recursable_dir(&self) -> bool {
         matches!(self, Kind::Directory)
     }
 

gix-dir/src/walk/classify.rs

@@ -253,13 +253,6 @@ pub fn path(
         .map_err(Error::ExcludesAccess)?
     {
         if emit_ignored.is_some() {
-            if kind.map_or(false, |d| d.is_dir()) && out.pathspec_match.is_none() {
-                // we have patterns that didn't match at all. Try harder.
-                out.pathspec_match = ctx
-                    .pathspec
-                    .directory_matches_prefix(rela_path.as_bstr(), true)
-                    .then_some(PathspecMatch::Prefix);
-            }
             if matches!(
                 for_deletion,
                 Some(
@@ -275,6 +268,10 @@ pub fn path(
                     ),
                 );
             }
+            if kind.map_or(false, |d| d.is_recursable_dir()) && out.pathspec_match.is_none() {
+                // we have patterns that didn't match at all, *yet*. We want to look inside.
+                out.pathspec_match = Some(PathspecMatch::Prefix);
+            }
         }
         return Ok(out
             .with_status(entry::Status::Ignored(excluded))

gix-dir/tests/fixtures/many.sh

@@ -159,6 +159,13 @@ git init partial-checkout-non-cone
   mkdir d && touch d/file-created-manually
 )
 
+git init precious-nested-repository
+(cd precious-nested-repository
+  echo '$precious*/' > .gitignore
+  git init precious-repo
+  git add .gitignore && git commit -m "init"
+)
+
 git init only-untracked
 (cd only-untracked
   >a

gix-dir/tests/walk/mod.rs

@@ -1208,6 +1208,38 @@ fn untracked_and_ignored_for_deletion_nonmatching_wildcard_spec() -> crate::Resu
     );
     Ok(())
 }
+#[test]
+fn nested_precious_repo_respects_wildcards() -> crate::Result {
+    let root = fixture("precious-nested-repository");
+    for for_deletion in [
+        Some(ForDeletionMode::FindNonBareRepositoriesInIgnoredDirectories),
+        Some(ForDeletionMode::FindRepositoriesInIgnoredDirectories),
+    ] {
+        let (_out, entries) = collect_filtered(
+            &root,
+            None,
+            |keep, ctx| {
+                walk(
+                    &root,
+                    ctx,
+                    walk::Options {
+                        emit_ignored: Some(CollapseDirectory),
+                        emit_untracked: CollapseDirectory,
+                        emit_pruned: false,
+                        for_deletion,
+                        ..options()
+                    },
+                    keep,
+                )
+            },
+            Some("*foo/"),
+        );
+        // NOTE: do not use `_out` as `.git` directory contents can change, it's controlled by Git, causing flakiness.
+
+        assert_eq!(entries, [], "nothing matches, of course");
+    }
+    Ok(())
+}
 
 #[test]
 fn nested_ignored_dirs_for_deletion_nonmatching_wildcard_spec() -> crate::Result {