Skip to content

Commit 0155aec

Browse files
authored
Merge pull request #1670 from EliahKagan/run-ci/cargo-deny
Split cargo-deny job into two non-matrix jobs
2 parents d47263b + a52a2a1 commit 0155aec

File tree

1 file changed

+12
-9
lines changed

1 file changed

+12
-9
lines changed

.github/workflows/ci.yml

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -192,23 +192,25 @@ jobs:
192192
# than allows is no problem either if it comes to that.
193193
continue-on-error: true
194194

195-
cargo-deny:
195+
# This job is not required for PR auto-merge, so that sudden announcement of a
196+
# new advisory does not keep otherwise OK pull requests from being integrated.
197+
cargo-deny-advisories:
196198
runs-on: ubuntu-latest
197199

198-
strategy:
199-
matrix:
200-
checks:
201-
- advisories
202-
- bans licenses sources
200+
steps:
201+
- uses: actions/checkout@v4
202+
- uses: EmbarkStudios/cargo-deny-action@v2
203+
with:
204+
command: check advisories
203205

204-
# Prevent sudden announcement of a new advisory from failing ci:
205-
continue-on-error: ${{ matrix.checks == 'advisories' }}
206+
cargo-deny:
207+
runs-on: ubuntu-latest
206208

207209
steps:
208210
- uses: actions/checkout@v4
209211
- uses: EmbarkStudios/cargo-deny-action@v2
210212
with:
211-
command: check ${{ matrix.checks }}
213+
command: check bans licenses sources
212214

213215
wasm:
214216
name: WebAssembly
@@ -300,6 +302,7 @@ jobs:
300302
# List all jobs that are intended NOT to block PR auto-merge here.
301303
EXPECTED_NONBLOCKING_JOBS: |-
302304
test-fixtures-windows
305+
cargo-deny-advisories
303306
wasm
304307
tests-pass
305308

0 commit comments

Comments
 (0)