remove tagNamePattern option

Author: Simon Ejsing

src/GitVersionCore.Tests/TestEffectiveConfiguration.cs

@@ -16,7 +16,6 @@ public TestEffectiveConfiguration(
             string nextVersion = null,
             string branchPrefixToTrim = "",
             bool preventIncrementForMergedBranchVersion = false,
-            string tagNamePattern = null,
             string tagNumberPattern = null,
             string continuousDeploymentFallbackTag = "ci",
             bool trackMergeTarget = false,
@@ -30,7 +29,7 @@ public TestEffectiveConfiguration(
             IEnumerable<IVersionFilter> versionFilters = null
             ) :
             base(assemblyVersioningScheme, assemblyInformationalFormat, versioningMode, gitTagPrefix, tag, nextVersion, IncrementStrategy.Patch,
-                    branchPrefixToTrim, preventIncrementForMergedBranchVersion, tagNamePattern, tagNumberPattern, continuousDeploymentFallbackTag,
+                    branchPrefixToTrim, preventIncrementForMergedBranchVersion, tagNumberPattern, continuousDeploymentFallbackTag,
                     trackMergeTarget,
                     majorMessage, minorMessage, patchMessage,
                     commitMessageMode, legacySemVerPadding, buildMetaDataPadding, commitsSinceVersionSourcePadding,

src/GitVersionCore/Configuration/BranchConfig.cs

@@ -14,7 +14,6 @@ public BranchConfig(BranchConfig branchConfiguration)
             Tag = branchConfiguration.Tag;
             Increment = branchConfiguration.Increment;
             PreventIncrementOfMergedBranchVersion = branchConfiguration.PreventIncrementOfMergedBranchVersion;
-            TagNamePattern = branchConfiguration.TagNamePattern;
             TagNumberPattern = branchConfiguration.TagNumberPattern;
             TrackMergeTarget = branchConfiguration.TrackMergeTarget;
             CommitMessageIncrementing = branchConfiguration.CommitMessageIncrementing;
@@ -35,9 +34,6 @@ public BranchConfig(BranchConfig branchConfiguration)
         [YamlMember(Alias = "prevent-increment-of-merged-branch-version")]
         public bool? PreventIncrementOfMergedBranchVersion { get; set; }
 
-        [YamlMember(Alias = "tag-name-pattern")]
-        public string TagNamePattern { get; set; }
-
         [YamlMember(Alias = "tag-number-pattern")]
         public string TagNumberPattern { get; set; }
 

src/GitVersionCore/Configuration/ConfigurationProvider.cs

@@ -114,11 +114,9 @@ public static void ApplyBranchDefaults(Config config,
             bool defaultPreventIncrement = false,
             VersioningMode? defaultVersioningMode = null, // Looked up from main config
             bool defaultTrackMergeTarget = false,
-            string defaultTagNumberPattern = null,
-            string defaultTagNamePattern = null)
+            string defaultTagNumberPattern = null)
         {
             branchConfig.Tag = branchConfig.Tag ?? defaultTag;
-            branchConfig.TagNamePattern = branchConfig.TagNamePattern ?? defaultTagNamePattern;
             branchConfig.TagNumberPattern = branchConfig.TagNumberPattern ?? defaultTagNumberPattern;
             branchConfig.Increment = branchConfig.Increment ?? defaultIncrementStrategy;
             branchConfig.PreventIncrementOfMergedBranchVersion = branchConfig.PreventIncrementOfMergedBranchVersion ?? defaultPreventIncrement;

src/GitVersionCore/EffectiveConfiguration.cs

@@ -15,7 +15,6 @@ public EffectiveConfiguration(
             string tag, string nextVersion, IncrementStrategy increment,
             string branchPrefixToTrim,
             bool preventIncrementForMergedBranchVersion,
-            string tagNamePattern,
             string tagNumberPattern,
             string continuousDeploymentFallbackTag,
             bool trackMergeTarget,
@@ -38,7 +37,6 @@ IEnumerable<IVersionFilter> versionFilters
             Increment = increment;
             BranchPrefixToTrim = branchPrefixToTrim;
             PreventIncrementForMergedBranchVersion = preventIncrementForMergedBranchVersion;
-            TagNamePattern = tagNamePattern;
             TagNumberPattern = tagNumberPattern;
             ContinuousDeploymentFallbackTag = continuousDeploymentFallbackTag;
             TrackMergeTarget = trackMergeTarget;
@@ -75,8 +73,6 @@ IEnumerable<IVersionFilter> versionFilters
 
         public bool PreventIncrementForMergedBranchVersion { get; private set; }
 
-        public string TagNamePattern { get; private set; }
-
         public string TagNumberPattern { get; private set; }
 
         public string ContinuousDeploymentFallbackTag { get; private set; }

src/GitVersionCore/GitVersionContext.cs

@@ -96,7 +96,6 @@ void CalculateEffectiveConfiguration()
 
             var versioningMode = currentBranchConfig.Value.VersioningMode.Value;
             var tag = currentBranchConfig.Value.Tag;
-            var tagNamePattern = currentBranchConfig.Value.TagNamePattern;
             var tagNumberPattern = currentBranchConfig.Value.TagNumberPattern;
             var incrementStrategy = currentBranchConfig.Value.Increment.Value;
             var preventIncrementForMergedBranchVersion = currentBranchConfig.Value.PreventIncrementOfMergedBranchVersion.Value;
@@ -117,7 +116,6 @@ void CalculateEffectiveConfiguration()
                 assemblyVersioningScheme, assemblyInformationalFormat, versioningMode, gitTagPrefix,
                 tag, nextVersion, incrementStrategy, currentBranchConfig.Key,
                 preventIncrementForMergedBranchVersion,
-                tagNamePattern,
                 tagNumberPattern, configuration.ContinuousDeploymentFallbackTag,
                 trackMergeTarget,
                 majorMessage, minorMessage, patchMessage,