Use Path.DirectorySeparatorChar

Use Path.DirectorySeparatorChar instead of hard coded backslashes for improved Unix and Linux support.

Author: asbjornu

src/GitTools.Core.Tests/Git/GitRepositoryFactoryTests.cs

@@ -31,7 +31,7 @@ public void WorksCorrectlyWithRemoteRepository(string branchName, string expecte
             {
                 using (var fixture = new EmptyRepositoryFixture())
                 {
-                    var expectedDynamicRepoLocation = Path.Combine(tempPath, fixture.RepositoryPath.Split('\\').Last());
+                    var expectedDynamicRepoLocation = Path.Combine(tempPath, fixture.RepositoryPath.Split(Path.DirectorySeparatorChar).Last());
 
                     fixture.Repository.MakeCommits(5);
                     fixture.Repository.CreateFileAndCommit("TestFile.txt");
@@ -52,7 +52,7 @@ public void WorksCorrectlyWithRemoteRepository(string branchName, string expecte
                         dynamicRepositoryPath = gitRepository.DotGitDirectory;
 
                         gitRepository.IsDynamic.ShouldBe(true);
-                        gitRepository.DotGitDirectory.ShouldBe(expectedDynamicRepoLocation + "\\.git");
+                        gitRepository.DotGitDirectory.ShouldBe(expectedDynamicRepoLocation + Path.DirectorySeparatorChar + ".git");
 
                         var currentBranch = gitRepository.Repository.Head.CanonicalName;
 
@@ -133,7 +133,7 @@ public void PicksAnotherDirectoryNameWhenDynamicRepoFolderTaken()
                 {
                     fixture.Repository.CreateFileAndCommit("TestFile.txt");
                     File.Copy(Path.Combine(fixture.RepositoryPath, "TestFile.txt"), Path.Combine(tempDir, "TestFile.txt"));
-                    expectedDynamicRepoLocation = Path.Combine(tempPath, fixture.RepositoryPath.Split('\\').Last());
+                    expectedDynamicRepoLocation = Path.Combine(tempPath, fixture.RepositoryPath.Split(Path.DirectorySeparatorChar).Last());
                     Directory.CreateDirectory(expectedDynamicRepoLocation);
 
                     var repositoryInfo = new RepositoryInfo
@@ -145,7 +145,7 @@ public void PicksAnotherDirectoryNameWhenDynamicRepoFolderTaken()
                     using (var gitRepository = GitRepositoryFactory.CreateRepository(repositoryInfo))
                     {
                         gitRepository.IsDynamic.ShouldBe(true);
-                        gitRepository.DotGitDirectory.ShouldBe(expectedDynamicRepoLocation + "_1\\.git");
+                        gitRepository.DotGitDirectory.ShouldBe(expectedDynamicRepoLocation + "_1" + Path.DirectorySeparatorChar + ".git");
                     }
                 }
             }

src/GitTools.Core/GitTools.Core.Shared/Git/Extensions/LibGitExtensions.cs

@@ -99,12 +99,12 @@ public static string GetRepositoryDirectory(this IRepository repository, bool om
         {
             var gitDirectory = repository.Info.Path;
 
-            gitDirectory = gitDirectory.TrimEnd('\\');
+            gitDirectory = gitDirectory.TrimEnd(Path.DirectorySeparatorChar);
 
             if (omitGitPostFix && gitDirectory.EndsWith(".git"))
             {
                 gitDirectory = gitDirectory.Substring(0, gitDirectory.Length - ".git".Length);
-                gitDirectory = gitDirectory.TrimEnd('\\');
+                gitDirectory = gitDirectory.TrimEnd(Path.DirectorySeparatorChar);
             }
 
             return gitDirectory;