Use Path.Combine() instead of string concatenation

asbjornu · asbjornu · commit 542b85440b61 · 2016-04-20T11:39:53.000+02:00
diff --git a/src/GitTools.Core.Tests/Git/GitRepositoryFactoryTests.cs b/src/GitTools.Core.Tests/Git/GitRepositoryFactoryTests.cs
@@ -52,7 +52,7 @@ public void WorksCorrectlyWithRemoteRepository(string branchName, string expecte
                         dynamicRepositoryPath = gitRepository.DotGitDirectory;
 
                         gitRepository.IsDynamic.ShouldBe(true);
-                        gitRepository.DotGitDirectory.ShouldBe(expectedDynamicRepoLocation + Path.DirectorySeparatorChar + ".git");
+                        gitRepository.DotGitDirectory.ShouldBe(Path.Combine(expectedDynamicRepoLocation, ".git"));
 
                         var currentBranch = gitRepository.Repository.Head.CanonicalName;
 
@@ -145,7 +145,7 @@ public void PicksAnotherDirectoryNameWhenDynamicRepoFolderTaken()
                     using (var gitRepository = GitRepositoryFactory.CreateRepository(repositoryInfo))
                     {
                         gitRepository.IsDynamic.ShouldBe(true);
-                        gitRepository.DotGitDirectory.ShouldBe(expectedDynamicRepoLocation + "_1" + Path.DirectorySeparatorChar + ".git");
+                        gitRepository.DotGitDirectory.ShouldBe(Path.Combine(expectedDynamicRepoLocation + "_1", ".git"));
                     }
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ public void WorksCorrectlyWithRemoteRepository(string branchName, string expecte`
`52`	`52`	`dynamicRepositoryPath = gitRepository.DotGitDirectory;`
`53`	`53`
`54`	`54`	`gitRepository.IsDynamic.ShouldBe(true);`
`55`		`- gitRepository.DotGitDirectory.ShouldBe(expectedDynamicRepoLocation + Path.DirectorySeparatorChar + ".git");`
	`55`	`+ gitRepository.DotGitDirectory.ShouldBe(Path.Combine(expectedDynamicRepoLocation, ".git"));`
`56`	`56`
`57`	`57`	`var currentBranch = gitRepository.Repository.Head.CanonicalName;`
`58`	`58`
`@@ -145,7 +145,7 @@ public void PicksAnotherDirectoryNameWhenDynamicRepoFolderTaken()`
`145`	`145`	`using (var gitRepository = GitRepositoryFactory.CreateRepository(repositoryInfo))`
`146`	`146`	`{`
`147`	`147`	`gitRepository.IsDynamic.ShouldBe(true);`
`148`		`- gitRepository.DotGitDirectory.ShouldBe(expectedDynamicRepoLocation + "_1" + Path.DirectorySeparatorChar + ".git");`
	`148`	`+ gitRepository.DotGitDirectory.ShouldBe(Path.Combine(expectedDynamicRepoLocation + "_1", ".git"));`
`149`	`149`	`}`
`150`	`150`	`}`
`151`	`151`	`}`