Swallow IO exceptions

If deleting a file ends up with a `FileNotFoundException` or deleting a directory ends up with a `DirectoryNotFoundException`, there's no reason for the operation to fail; the file or directory is gone and we shouldn't care why we can't delete it.

Author: asbjornu

src/GitTools.Core.Tests/Git/GitRepositoryFactoryTests.cs

@@ -151,10 +151,10 @@ public void PicksAnotherDirectoryNameWhenDynamicRepoFolderTaken()
             }
             finally
             {
-                Directory.Delete(tempDir, true);
+                DeleteHelper.DeleteDirectory(tempDir, true);
                 if (expectedDynamicRepoLocation != null)
                 {
-                    Directory.Delete(expectedDynamicRepoLocation, true);
+                    DeleteHelper.DeleteDirectory(expectedDynamicRepoLocation, true);
                 }
 
                 if (expectedDynamicRepoLocation != null)

src/GitTools.Core/GitTools.Core.Shared/IO/Helpers/DeleteHelper.cs

@@ -11,17 +11,41 @@ public static void DeleteGitRepository(string directory)
                 return;
             }
 
-            foreach (var fileName in Directory.GetFiles(directory, "*.*", SearchOption.AllDirectories))
+            try
             {
-                var fileInfo = new FileInfo(fileName)
+                foreach (var fileName in Directory.GetFiles(directory, "*.*", SearchOption.AllDirectories))
                 {
-                    IsReadOnly = false
-                };
+                    var fileInfo = new FileInfo(fileName)
+                    {
+                        IsReadOnly = false
+                    };
 
-                fileInfo.Delete();
+                    try
+                    {
+                        fileInfo.Delete();
+                    }
+                    catch (FileNotFoundException)
+                    {
+                    }
+                }
+
+                Directory.Delete(directory, true);
+            }
+            catch (DirectoryNotFoundException)
+            {
             }
+        }
+
 
-            Directory.Delete(directory, true);
+        public static void DeleteDirectory(string directory, bool recursive)
+        {
+            try
+            {
+                Directory.Delete(directory, recursive);
+            }
+            catch (DirectoryNotFoundException)
+            {
+            }
         }
     }
 }