Default value for jobs method and fixing bug in pipeline class

moufmouf · moufmouf · commit 52f2b20caad4 · 2017-07-08T18:45:28.000+02:00
diff --git a/lib/Gitlab/Model/Pipeline.php b/lib/Gitlab/Model/Pipeline.php
@@ -32,7 +32,7 @@ public static function fromArray(Client $client, Project $project, array $data)
     {
         $pipeline = new static($project, $data['id'], $client);
 
-        return $job->hydrate($data);
+        return $pipeline->hydrate($data);
     }
 
     /**
diff --git a/lib/Gitlab/Model/Project.php b/lib/Gitlab/Model/Project.php
@@ -1097,7 +1097,7 @@ public function contributors()
      * @param array $scopes
      * @return Job[]
      */
-    public function jobs(array $scopes)
+    public function jobs(array $scopes = [])
     {
         $data = $this->api('jobs')->jobs($this->id, $scopes);
 

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ public static function fromArray(Client $client, Project $project, array $data)`
`32`	`32`	`{`
`33`	`33`	`$pipeline = new static($project, $data['id'], $client);`
`34`	`34`
`35`		`- return $job->hydrate($data);`
	`35`	`+ return $pipeline->hydrate($data);`
`36`	`36`	`}`
`37`	`37`
`38`	`38`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -1097,7 +1097,7 @@ public function contributors()`
`1097`	`1097`	`* @param array $scopes`
`1098`	`1098`	`* @return Job[]`
`1099`	`1099`	`*/`
`1100`		`- public function jobs(array $scopes)`
	`1100`	`+ public function jobs(array $scopes = [])`
`1101`	`1101`	`{`
`1102`	`1102`	`$data = $this->api('jobs')->jobs($this->id, $scopes);`
`1103`	`1103`