Issues with handleNoteOn

[noahpin]

Hello, I am having issues with the handleNoteOn callback. Through a MIDI monitor, I can see that every note that is being played on my DAW is being sent to the Arduino, but when I process all of the events going to handleNoteOn some notes arent being detected. I can see that the RX light blinks every time a new note is played, but a lot of the notes that are being dropped are in quick succession of one turning off. I'm not sure where I should look to try to fix this. My code is as follows:

#include <MIDI.h>
#include <Adafruit_GFX.h>
#include <Adafruit_SSD1331.h>
#include <SPI.h>
#include <FastLED.h>

#define LED_PIN     7
#define NUM_LEDS    100
#define CHIPSET     WS2811
#define COLOR_ORDER GRB
CRGB leds[NUM_LEDS];
#define BRIGHTNESS  128


// You can use any (4 or) 5 pins
#define sclk 13
#define mosi 11
#define cs   2
#define rst  4
#define dc   3


// Color definitions
#define  BLACK           0x0000
#define BLUE            0x001F
#define RED             0xF800
#define GREEN           0x07E0
#define CYAN            0x07FF
#define MAGENTA         0xF81F
#define YELLOW          0xFFE0
#define WHITE           0xFFFF

Adafruit_SSD1331 display = Adafruit_SSD1331(&SPI, cs, dc, rst);


// Create and bind the MIDI interface to the default hardware Serial port
MIDI_CREATE_DEFAULT_INSTANCE();
#define C3 48
int keys[12] = {48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59};
int pins[12] = {52, 22, 50, 24, 48, 46, 26, 44, 28, 42, 30, 40};
int stat[12] = {0,  0,  0,  0,  0,  0,  0,  0,  0,  0,  0,  0 };

void setup()
{
  MIDI.begin(MIDI_CHANNEL_OMNI);  // Listen to all incoming messages
  display.begin();
  MIDI.setInputChannel(MIDI_CHANNEL_OMNI);
  MIDI.setHandleNoteOn(hNoteOn);
  MIDI.setHandleNoteOff(hNoteOff);
  MIDI.setHandleClock(hClock);
  display.fillScreen(BLACK);
  MIDI.turnThruOff(); //fixed
  delay( 3000 ); // power-up safety delay
  FastLED.addLeds<CHIPSET, LED_PIN, COLOR_ORDER>(leds, NUM_LEDS).setCorrection( TypicalSMD5050 );
  FastLED.setBrightness( BRIGHTNESS );
  FastLED.clear();
  FastLED.show();
}

int a = 0;

void loop()
{
  ledHandler();
  for (int i = 0; i < 12; i++) {

    if (digitalRead(pins[i]) == HIGH)
    {
      if (stat[i] == 0) {
        MIDI.sendNoteOn(keys[i], 127, 1);
        stat[i] = 1;
      }
    }
    else {
      if (stat[i] == 1) {
        MIDI.sendNoteOff(keys[i], 0, 1);
        stat[i] = 0;
      }
    }
  }
  MIDI.read();
}
void hNoteOn(byte channel, byte note, byte velocity) {
  leds[note] = CRGB(255, 255, 255);
  display.drawPixel(note, 1, WHITE);
  ledHandler();

}
void hNoteOff(byte channel, byte note, byte velocity) {
  display.drawPixel(note, 1, BLACK);

}
void hClock(){
}
void ledHandler() {
  for (int i = 0; i < NUM_LEDS; i++) {
    leds[i] = CRGB(leds[i].r-0.5, leds[i].g-0.5, leds[i].b-0.5);
  }
  FastLED.show();
}

Thanks!

[franky47]

Am I correct in supposing that this performs some sort of fade-out effect ?

for (int i = 0; i < NUM_LEDS; i++) {
  leds[i] = CRGB(leds[i].r-0.5, leds[i].g-0.5, leds[i].b-0.5);
}

When you have a NoteOn event, this code runs twice (once in the loop, and once in the hNoteOn callback). Could that be the source of your problem ?

[noahpin]

Yes, this does perform a fade out effect. However, I added the function call in the noteOn handler after noticing that some lights weren't turning on as an attempt to fix it. Also, I have each note displaying on my OLED display as well, and the notes that aren't displaying on my LED strip are the same on the OLED.