Skip to content

Commit 6c71dd6

Browse files
committed
remove Object.assign polyfill from core-js
1 parent 98925cc commit 6c71dd6

File tree

4 files changed

+7
-16
lines changed

4 files changed

+7
-16
lines changed

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
"lint": "eslint --config .eslintrc \"./**/*.js\""
2020
},
2121
"dependencies": {
22-
"core-js": "^3.14.0",
2322
"prism-react-renderer": "^1.2.1",
2423
"sucrase": "^3.20.3",
2524
"use-editable": "^2.3.3"

src/utils/transpile/evalCode.js

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,7 @@
1-
import React from "react";
2-
import assign from "core-js/features/object/assign";
3-
4-
export const _poly = { assign };
5-
61
const evalCode = (code, scope) => {
72
const scopeKeys = Object.keys(scope);
83
const scopeValues = scopeKeys.map((key) => scope[key]);
9-
// eslint-disable-next-line no-new-func
10-
const res = new Function("_poly", "React", ...scopeKeys, code);
11-
return res(_poly, React, ...scopeValues);
4+
return new Function(...scopeKeys, code)(...scopeValues);
125
};
136

147
export default evalCode;

src/utils/transpile/index.js

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import React from "react";
12
import transform from "./transform";
23
import errorBoundary from "./errorBoundary";
34
import evalCode from "./evalCode";
@@ -8,7 +9,10 @@ export const generateElement = ({ code = "", scope = {} }, errorCallback) => {
89

910
// NOTE: Workaround for classes and arrow functions.
1011
const transformed = transform(`return (${codeTrimmed})`).trim();
11-
return errorBoundary(evalCode(transformed, scope), errorCallback);
12+
return errorBoundary(
13+
evalCode(transformed, { React, ...scope }),
14+
errorCallback
15+
);
1216
};
1317

1418
export const renderElementAsync = (
@@ -31,5 +35,5 @@ export const renderElementAsync = (
3135
);
3236
}
3337

34-
evalCode(transform(code), { ...scope, render });
38+
evalCode(transform(code), { React, ...scope, render });
3539
};

yarn.lock

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4363,11 +4363,6 @@ core-js@^3.0.4, core-js@^3.6.5, core-js@^3.8.2:
43634363
resolved "https://registry.yarnpkg.com/core-js/-/core-js-3.16.0.tgz#1d46fb33720bc1fa7f90d20431f36a5540858986"
43644364
integrity sha512-5+5VxRFmSf97nM8Jr2wzOwLqRo6zphH2aX+7KsAUONObyzakDNq2G/bgbhinxB4PoV9L3aXQYhiDKyIKWd2c8g==
43654365

4366-
core-js@^3.14.0:
4367-
version "3.14.0"
4368-
resolved "https://registry.yarnpkg.com/core-js/-/core-js-3.14.0.tgz#62322b98c71cc2018b027971a69419e2425c2a6c"
4369-
integrity sha512-3s+ed8er9ahK+zJpp9ZtuVcDoFzHNiZsPbNAAE4KXgrRHbjSqqNN6xGSXq6bq7TZIbKj4NLrLb6bJ5i+vSVjHA==
4370-
43714366
core-util-is@1.0.2, core-util-is@~1.0.0:
43724367
version "1.0.2"
43734368
resolved "https://registry.npmjs.org/core-util-is/-/core-util-is-1.0.2.tgz#b5fd54220aa2bc5ab57aab7140c940754503c1a7"

0 commit comments

Comments
 (0)