From b66d0ab433e73ae86ba4575df4015c10a7e73afa Mon Sep 17 00:00:00 2001 From: Niklas Ekman Date: Wed, 20 Jun 2018 12:01:03 +0200 Subject: [PATCH 1/2] Bugfix in Number::fromString() test --- tests/NumberTest.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/NumberTest.php b/tests/NumberTest.php index f17d076..b03d7ca 100644 --- a/tests/NumberTest.php +++ b/tests/NumberTest.php @@ -53,17 +53,17 @@ public function provideFromString_success() /** * @dataProvider provideFromString_fail */ - public function testFromString_fail($number, $checkDigit, $expected) + public function testFromString_fail($number, $expected) { $this->expectException($expected); - new Number($number, $checkDigit); + Number::fromString($number); } public function provideFromString_fail() { return [ - ['', 1, \InvalidArgumentException::class], - ['xyz ', null, \InvalidArgumentException::class], + ['', \InvalidArgumentException::class], + ['xyz ', \InvalidArgumentException::class], ]; } From 6bc18d4317e3d76599b3e4eca2603f77c8a4f341 Mon Sep 17 00:00:00 2001 From: Niklas Ekman Date: Wed, 20 Jun 2018 13:43:44 +0200 Subject: [PATCH 2/2] Update LuhnAlgorithmTest.php --- tests/LuhnAlgorithmTest.php | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/LuhnAlgorithmTest.php b/tests/LuhnAlgorithmTest.php index 2faf68a..4aeb9dd 100644 --- a/tests/LuhnAlgorithmTest.php +++ b/tests/LuhnAlgorithmTest.php @@ -58,6 +58,7 @@ public function provideIsValid_success() [new Number('410321920', 2), true], [new Number('3199723370002', 0), true], [new Number('8914800000397416568', 5), true], + [new Number('12345', 6), false], ]; }