scc logic modified and test added

Author: Debashis08

Headers/0003_Graph/0004_StronglyConnectedComponents.h

@@ -29,7 +29,7 @@ class StronglyConnectedComponentsGraph
     vector<vector<int>> _allConnectedComponents;
     SCCNode* MakeOrFindNode(int value);
     void DepthFirstSearchOnGraphG(SCCNode* DFSNode);
-    vector<int> DepthFirstSearchOnGraphT(SCCNode* DFSNode, vector<int> connectedComponents);
+    void DepthFirstSearchOnGraphT(SCCNode* DFSNode, vector<int>& connectedComponents);
 public:
     void PushDirectedEdge(int valueU, int valueV);
     void PushSingleNode(int valueU);

SourceCodes/0003_Graph/0004_StronglyConnectedComponents.cc

@@ -47,7 +47,7 @@ void StronglyConnectedComponentsGraph::DepthFirstSearchOnGraphG(SCCNode* nodeU)
 	this->_nodesFinishingTimeOrder.push_front(nodeU);
 }
 
-vector<int> StronglyConnectedComponentsGraph::DepthFirstSearchOnGraphT(SCCNode* nodeU, vector<int> connectedComponents)
+void StronglyConnectedComponentsGraph::DepthFirstSearchOnGraphT(SCCNode* nodeU, vector<int>& connectedComponents)
 {
 	nodeU->color = GRAY;
 	connectedComponents.push_back(nodeU->data);
@@ -60,7 +60,6 @@ vector<int> StronglyConnectedComponentsGraph::DepthFirstSearchOnGraphT(SCCNode*
 		}
 	}
 	nodeU->color = BLACK;
-	return connectedComponents;
 }
 
 void StronglyConnectedComponentsGraph::PushDirectedEdge(int valueU, int valueV)
@@ -105,8 +104,8 @@ void StronglyConnectedComponentsGraph::DFSOnGraphT()
 		if (iterator->color == WHITE)
 		{
 			vector<int> connectedComponents;
-			auto result = this->DepthFirstSearchOnGraphT(iterator, connectedComponents);
-			this->_allConnectedComponents.push_back(result);
+			this->DepthFirstSearchOnGraphT(iterator, connectedComponents);
+			this->_allConnectedComponents.push_back(connectedComponents);
 		}
 	}
 }

Tests/0000_CommonUtilities/UnitTestHelper.h

@@ -63,6 +63,10 @@ class UnitTestHelper
 			{
 				result += to_string(it) + " ";
 			}
+			if (!result.empty())
+			{
+				result.pop_back();
+			}
 			result += "]";
 		}
 		return result;

Tests/0003_Graph/0004_StronglyConnectedComponentsTest.cc

@@ -11,22 +11,22 @@ namespace StronglyConnectedComponentsTest
 		StronglyConnectedComponentsGraph graph;
 
 		graph.PushDirectedEdge(1, 2);
+		graph.PushDirectedEdge(1, 5);
 		graph.PushDirectedEdge(2, 3);
-		graph.PushDirectedEdge(2, 5);
-		graph.PushDirectedEdge(2, 6);
-		graph.PushDirectedEdge(3, 4);
-		graph.PushDirectedEdge(3, 7);
-		graph.PushDirectedEdge(4, 3);
-		graph.PushDirectedEdge(4, 8);
+		graph.PushDirectedEdge(2, 4);
+		graph.PushDirectedEdge(3, 2);
+		graph.PushDirectedEdge(4, 4);
 		graph.PushDirectedEdge(5, 1);
-		graph.PushDirectedEdge(5, 6);
+		graph.PushDirectedEdge(5, 4);
+		graph.PushDirectedEdge(6, 1);
+		graph.PushDirectedEdge(6, 3);
 		graph.PushDirectedEdge(6, 7);
-		graph.PushDirectedEdge(7, 6);
+		graph.PushDirectedEdge(7, 3);
 		graph.PushDirectedEdge(7, 8);
-		graph.PushDirectedEdge(8, 8);
+		graph.PushDirectedEdge(8, 6);
 
 		string actualResult = unitTestHelper.VerifyVectorResult(graph.FindAllStronglyConnectedComponents());
-		string expectedResult = "";
+		string expectedResult = "[6 8 7][1 5][2 3][4]";
 		EXPECT_EQ(actualResult, expectedResult);
 	}
 }