rubocop fixes

Author: binford2k

lib/puppet/functions/stdlib/abs.rb

@@ -40,10 +40,7 @@
     repeated_param 'Any', :arguments
   end
 
-
   def default_impl(*arguments)
-    
-
     raise(Puppet::ParseError, "abs(): Wrong number of arguments given (#{arguments.size} for 1)") if arguments.empty?
 
     value = arguments[0]
@@ -62,7 +59,6 @@ def default_impl(*arguments)
     # We have numeric value to handle ...
     result = value.abs
 
-    return result
-  
+    result
   end
 end

lib/puppet/functions/stdlib/any2array.rb

@@ -57,10 +57,7 @@
     repeated_param 'Any', :arguments
   end
 
-
   def default_impl(*arguments)
-    
-
     if arguments.empty?
       return []
     end
@@ -75,7 +72,6 @@ def default_impl(*arguments)
       end
       return result
     end
-    return arguments
-  
+    arguments
   end
 end

lib/puppet/functions/stdlib/any2bool.rb

@@ -43,10 +43,7 @@
     repeated_param 'Any', :arguments
   end
 
-
   def default_impl(*arguments)
-    
-
     raise(Puppet::ParseError, "any2bool(): Wrong number of arguments given (#{arguments.size} for 1)") if arguments.empty?
 
     # If argument is already Boolean, return it
@@ -79,7 +76,6 @@ def default_impl(*arguments)
       return function_str2bool([arguments[0]])
     end
 
-    return true
-  
+    true
   end
 end

lib/puppet/functions/stdlib/assert_private.rb

@@ -35,10 +35,7 @@
     repeated_param 'Any', :args
   end
 
-
   def default_impl(*args)
-    
-
     raise(Puppet::ParseError, "assert_private(): Wrong number of arguments given (#{args.size}}) for 0 or 1)") if args.size > 1
 
     scope = self
@@ -54,6 +51,5 @@ def default_impl(*args)
       end
       raise(Puppet::ParseError, message)
     end
-  
   end
 end

lib/puppet/functions/stdlib/base64.rb

@@ -56,10 +56,7 @@
     repeated_param 'Any', :args
   end
 
-
   def default_impl(*args)
-    
-
     require 'base64'
 
     raise Puppet::ParseError, "base64(): Wrong number of arguments (#{args.length}; must be >= 2)" unless args.length >= 2
@@ -107,7 +104,6 @@ def default_impl(*args)
       end
     end
 
-    return result
-  
+    result
   end
 end

lib/puppet/functions/stdlib/basename.rb

@@ -32,10 +32,7 @@
     repeated_param 'Any', :arguments
   end
 
-
   def default_impl(*arguments)
-    
-
     raise(Puppet::ParseError, 'basename(): No arguments given') if arguments.empty?
     raise(Puppet::ParseError, "basename(): Too many arguments given (#{arguments.size})") if arguments.size > 2
     raise(Puppet::ParseError, 'basename(): Requires string as first argument') unless arguments[0].is_a?(String)
@@ -46,7 +43,6 @@ def default_impl(*arguments)
       rv = File.basename(arguments[0], arguments[1])
     end
 
-    return rv
-  
+    rv
   end
 end

lib/puppet/functions/stdlib/bool2num.rb

@@ -51,18 +51,14 @@
     repeated_param 'Any', :arguments
   end
 
-
   def default_impl(*arguments)
-    
-
     raise(Puppet::ParseError, "bool2num(): Wrong number of arguments given (#{arguments.size} for 1)") if arguments.empty?
 
     value = function_str2bool([arguments[0]])
 
     # We have real boolean values as well ...
     result = value ? 1 : 0
 
-    return result
-  
+    result
   end
 end

lib/puppet/functions/stdlib/bool2str.rb

@@ -60,10 +60,7 @@
     repeated_param 'Any', :arguments
   end
 
-
   def default_impl(*arguments)
-    
-
     unless arguments.size == 1 || arguments.size == 3
       raise(Puppet::ParseError, "bool2str(): Wrong number of arguments given (#{arguments.size} for 3)")
     end
@@ -82,7 +79,6 @@ def default_impl(*arguments)
       raise(Puppet::ParseError, 'bool2str(): Requires strings to convert to')
     end
 
-    return value ? true_string : false_string
-  
+    value ? true_string : false_string
   end
 end

lib/puppet/functions/stdlib/camelcase.rb

@@ -39,10 +39,7 @@
     repeated_param 'Any', :arguments
   end
 
-
   def default_impl(*arguments)
-    
-
     raise(Puppet::ParseError, "camelcase(): Wrong number of arguments given (#{arguments.size} for 1)") if arguments.empty?
 
     value = arguments[0]
@@ -59,7 +56,6 @@ def default_impl(*arguments)
                value.split('_').map { |e| e.capitalize }.join
              end
 
-    return result
-  
+    result
   end
 end

lib/puppet/functions/stdlib/capitalize.rb

@@ -41,10 +41,7 @@
     repeated_param 'Any', :arguments
   end
 
-
   def default_impl(*arguments)
-    
-
     raise(Puppet::ParseError, "capitalize(): Wrong number of arguments given (#{arguments.size} for 1)") if arguments.empty?
 
     value = arguments[0]
@@ -60,7 +57,6 @@ def default_impl(*arguments)
                value.capitalize
              end
 
-    return result
-  
+    result
   end
 end

lib/puppet/functions/stdlib/ceiling.rb

@@ -37,10 +37,7 @@
     repeated_param 'Any', :arguments
   end
 
-
   def default_impl(*arguments)
-    
-
     raise(Puppet::ParseError, "ceiling(): Wrong number of arguments given (#{arguments.size} for 1)") if arguments.size != 1
 
     begin
@@ -52,6 +49,5 @@ def default_impl(*arguments)
     raise(Puppet::ParseError, "ceiling(): Wrong argument type given (#{arg.class} for Numeric)") if arg.is_a?(Numeric) == false
 
     arg.ceil
-  
   end
 end

lib/puppet/functions/stdlib/chomp.rb

@@ -16,7 +16,7 @@
 #      **Deprecated** Removes the record separator from the end of a string or an array of strings.
 #
 #    For example `hello
-#` becomes `hello`.
+# ` becomes `hello`.
 #    Requires a single string or array as an input.
 #
 #    > *Note:*
@@ -41,10 +41,7 @@
     repeated_param 'Any', :arguments
   end
 
-
   def default_impl(*arguments)
-    
-
     raise(Puppet::ParseError, "chomp(): Wrong number of arguments given (#{arguments.size} for 1)") if arguments.empty?
 
     value = arguments[0]
@@ -60,7 +57,6 @@ def default_impl(*arguments)
                value.chomp
              end
 
-    return result
-  
+    result
   end
 end

lib/puppet/functions/stdlib/chop.rb

@@ -16,7 +16,7 @@
 #      **Deprecated** Returns a new string with the last character removed.
 #
 #    If the string ends with `
-#`, both characters are removed. Applying
+# `, both characters are removed. Applying
 #    chop to an empty string returns an empty string. If you wish to merely
 #    remove record separators then you should use the `chomp` function.
 #    Requires a string or array of strings as input.
@@ -41,10 +41,7 @@
     repeated_param 'Any', :arguments
   end
 
-
   def default_impl(*arguments)
-    
-
     raise(Puppet::ParseError, "chop(): Wrong number of arguments given (#{arguments.size} for 1)") if arguments.empty?
 
     value = arguments[0]
@@ -60,7 +57,6 @@ def default_impl(*arguments)
                value.chop
              end
 
-    return result
-  
+    result
   end
 end

lib/puppet/functions/stdlib/clamp.rb

@@ -46,10 +46,7 @@
     repeated_param 'Any', :args
   end
 
-
   def default_impl(*args)
-    
-
     args.flatten!
 
     raise(Puppet::ParseError, 'clamp(): Wrong number of arguments, need three to clamp') if args.size != 3
@@ -67,6 +64,5 @@ def default_impl(*args)
     # convert to numeric each element
     # then sort them and get a middle value
     args.map { |n| n.to_i }.sort[1]
-  
   end
 end

lib/puppet/functions/stdlib/concat.rb

@@ -45,10 +45,7 @@
     repeated_param 'Any', :arguments
   end
 
-
   def default_impl(*arguments)
-    
-
     # Check that more than 2 arguments have been given ...
     raise(Puppet::ParseError, "concat(): Wrong number of arguments given (#{arguments.size} for < 2)") if arguments.size < 2
 
@@ -66,7 +63,6 @@ def default_impl(*arguments)
       result += (x.is_a?(Array) ? x : [x])
     end
 
-    return result
-  
+    result
   end
 end

lib/puppet/functions/stdlib/convert_base.rb

@@ -50,10 +50,7 @@
     repeated_param 'Any', :args
   end
 
-
   def default_impl(*args)
-    
-
     raise Puppet::ParseError, 'convert_base(): First argument must be either a string or an integer' unless args[0].is_a?(Integer) || args[0].is_a?(String)
     raise Puppet::ParseError, 'convert_base(): Second argument must be either a string or an integer' unless args[1].is_a?(Integer) || args[1].is_a?(String)
 
@@ -73,7 +70,6 @@ def default_impl(*args)
 
     raise Puppet::ParseError, 'convert_base(): base must be at least 2 and must not be greater than 36' unless new_base >= 2 && new_base <= 36
 
-    return number_to_convert.to_s(new_base)
-  
+    number_to_convert.to_s(new_base)
   end
 end

lib/puppet/functions/stdlib/count.rb

@@ -48,10 +48,7 @@
     repeated_param 'Any', :args
   end
 
-
   def default_impl(*args)
-    
-
     if args.size > 2
       raise(ArgumentError, "count(): Wrong number of arguments given #{args.size} for 1 or 2.")
     end
@@ -63,6 +60,5 @@ def default_impl(*args)
     else
       collection.count { |obj| !obj.nil? && obj != :undef && obj != '' }
     end
-  
   end
 end

lib/puppet/functions/stdlib/deep_merge.rb

@@ -45,10 +45,7 @@
     repeated_param 'Any', :args
   end
 
-
   def default_impl(*args)
-    
-
     if args.length < 2
       raise Puppet::ParseError, "deep_merge(): wrong number of arguments (#{args.length}; must be at least 2)"
     end
@@ -73,7 +70,6 @@ def default_impl(*args)
 
       result = deep_merge.call(result, arg)
     end
-    return(result)
-  
+    result
   end
 end