Skip to content

Commit 6b4507d

Browse files
committed
Simplify test case definition by removing redundant "usesEnv" and "usesScript" properties.
1 parent 18e16f6 commit 6b4507d

File tree

1 file changed

+19
-34
lines changed

1 file changed

+19
-34
lines changed

test/markdownlint-cli2-test-cases.js

Lines changed: 19 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,9 @@ const testCases =
2121

2222
const testCase = (options) => {
2323
const { name, script, args, exitCode, cwd, env, stderrRe, pre, post,
24-
noRequire, usesEnv, usesRequire, usesScript } = options;
24+
noRequire, usesRequire } = options;
25+
const usesEnv = Boolean(env);
26+
const usesScript = Boolean(script);
2527
if (
2628
(noRequire && !includeNoRequire) ||
2729
(usesEnv && !includeEnv) ||
@@ -127,26 +129,23 @@ const testCases =
127129
"script": "markdownlint-cli2-fix.js",
128130
"args": [],
129131
"exitCode": 2,
130-
"cwd": "no-config",
131-
"usesScript": true
132+
"cwd": "no-config"
132133
});
133134

134135
testCase({
135136
"name": "no-arguments-config",
136137
"script": "markdownlint-cli2-config.js",
137138
"args": [],
138139
"exitCode": 2,
139-
"cwd": "no-config",
140-
"usesScript": true
140+
"cwd": "no-config"
141141
});
142142

143143
testCase({
144144
"name": "one-argument-config",
145145
"script": "markdownlint-cli2-config.js",
146146
"args": [ "../config-files/cfg/.markdownlint-cli2.jsonc" ],
147147
"exitCode": 2,
148-
"cwd": "no-config",
149-
"usesScript": true
148+
"cwd": "no-config"
150149
});
151150

152151
testCase({
@@ -499,16 +498,14 @@ const testCases =
499498
"exitCode": 1,
500499
"cwd": directoryName("fix-default-true"),
501500
"pre": copyDirectory,
502-
"post": deleteDirectory,
503-
"usesScript": true
501+
"post": deleteDirectory
504502
});
505503

506504
testCase({
507505
"name": "fix-default-true-override",
508506
"script": "markdownlint-cli2-fix.js",
509507
"args": [ "**/*.md" ],
510-
"exitCode": 1,
511-
"usesScript": true
508+
"exitCode": 1
512509
});
513510

514511
const configFiles = [
@@ -529,16 +526,14 @@ const testCases =
529526
"script": "markdownlint-cli2-config.js",
530527
"args": [ `cfg/${configFile}`, "**/*.md" ],
531528
"exitCode": 1,
532-
"cwd": "config-files",
533-
"usesScript": true
529+
"cwd": "config-files"
534530
});
535531
testCase({
536532
"name": `config-files-${configFile}-alternate`,
537533
"script": "markdownlint-cli2-config.js",
538534
"args": [ `cfg/alternate${configFile}`, "**/*.md" ],
539535
"exitCode": 1,
540-
"cwd": "config-files",
541-
"usesScript": true
536+
"cwd": "config-files"
542537
});
543538
testCase({
544539
"name": `config-files-${configFile}-absolute`,
@@ -548,8 +543,7 @@ const testCases =
548543
"**/*.md"
549544
],
550545
"exitCode": 1,
551-
"cwd": "config-files",
552-
"usesScript": true
546+
"cwd": "config-files"
553547
});
554548
}
555549

@@ -576,8 +570,7 @@ const testCases =
576570
"exitCode": 2,
577571
stderrRe,
578572
"cwd": "config-files",
579-
"usesRequire": true,
580-
"usesScript": true
573+
"usesRequire": true
581574
});
582575
}
583576

@@ -592,8 +585,7 @@ const testCases =
592585
"script": "markdownlint-cli2-config.js",
593586
"args": [ redundantConfigFile, "*.md" ],
594587
"exitCode": 1,
595-
"cwd": redundantConfigFile.slice(1).replace(".", "-"),
596-
"usesScript": true
588+
"cwd": redundantConfigFile.slice(1).replace(".", "-")
597589
});
598590
}
599591

@@ -605,25 +597,22 @@ const testCases =
605597
"stderrRe":
606598
// eslint-disable-next-line max-len
607599
/Configuration file "cfg\/unrecognized\.jsonc" is unrecognized; its name should be \(or end with\) one of the supported types \(e\.g\., "\.markdownlint\.json" or "example\.markdownlint-cli2\.jsonc"\)\./u,
608-
"cwd": "config-files",
609-
"usesScript": true
600+
"cwd": "config-files"
610601
});
611602

612603
testCase({
613604
"name": "config-relative-commonjs",
614605
"script": "markdownlint-cli2-config.js",
615606
"args": [ "config/.markdownlint-cli2.jsonc", "viewme.md", "link.md" ],
616607
"exitCode": 1,
617-
"usesRequire": true,
618-
"usesScript": true
608+
"usesRequire": true
619609
});
620610

621611
testCase({
622612
"name": "config-relative-module",
623613
"script": "markdownlint-cli2-config.js",
624614
"args": [ "config/.markdownlint-cli2.jsonc", "viewme.md", "link.md" ],
625-
"exitCode": 1,
626-
"usesScript": true
615+
"exitCode": 1
627616
});
628617

629618
testCase({
@@ -633,8 +622,7 @@ const testCases =
633622
"exitCode": 0,
634623
"cwd": directoryName("config-with-fix"),
635624
"pre": copyDirectory,
636-
"post": deleteDirectory,
637-
"usesScript": true
625+
"post": deleteDirectory
638626
});
639627

640628
testCase({
@@ -710,7 +698,6 @@ const testCases =
710698
"FORCE_COLOR": 1,
711699
"FORCE_HYPERLINK": 1
712700
},
713-
"usesEnv": true,
714701
"usesRequire": true
715702
});
716703

@@ -783,8 +770,7 @@ const testCases =
783770
"env": {
784771
"FORCE_COLOR": 1,
785772
"FORCE_HYPERLINK": 1
786-
},
787-
"usesEnv": true
773+
}
788774
});
789775

790776
testCase({
@@ -793,8 +779,7 @@ const testCases =
793779
"exitCode": 1,
794780
"env": {
795781
"FORCE_COLOR": 1
796-
},
797-
"usesEnv": true
782+
}
798783
});
799784

800785
testCase({

0 commit comments

Comments
 (0)