Skip to content

Commit dce16c0

Browse files
committed
Remove global span caching.
1 parent 71da20a commit dce16c0

File tree

1 file changed

+2
-30
lines changed

1 file changed

+2
-30
lines changed

tests/test_tracing.py

Lines changed: 2 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -50,32 +50,6 @@
5050

5151
event_samples = "tests/event_samples/"
5252

53-
span_to_finish = None
54-
55-
56-
def _clean_up_span():
57-
global span_to_finish
58-
if span_to_finish is not None:
59-
span_to_finish.finish()
60-
span_to_finish = None
61-
62-
63-
def register_span(span):
64-
global span_to_finish
65-
_clean_up_span()
66-
span_to_finish = span
67-
return span
68-
69-
70-
def wrapped_span_creator(span_creator_func):
71-
def result_func(*args, **kwargs):
72-
return register_span(span_creator_func(*args, **kwargs))
73-
74-
return result_func
75-
76-
77-
create_inferred_span = wrapped_span_creator(create_inferred_span)
78-
7953

8054
class ClientContext(object):
8155
def __init__(self, custom=None):
@@ -1709,20 +1683,18 @@ def test_create_inferred_span(mock_span_finish, source, expect):
17091683
assert actual.get_tag(tag) == value, f"wrong value for tag {tag}"
17101684

17111685
if expect.parent_name is not None:
1712-
assert mock_span_finish.call_count == 2
1686+
assert mock_span_finish.call_count == 1
17131687
args, kwargs = mock_span_finish.call_args_list[0]
17141688
parent = args[0]
17151689
finish_time = kwargs.get("finish_time") or args[1]
17161690
assert parent.name == expect.parent_name
17171691
assert actual.parent_id == parent.span_id
17181692
assert finish_time == expect.start
17191693
else:
1720-
assert mock_span_finish.call_count < 2
1694+
assert mock_span_finish.call_count == 0
17211695

17221696

17231697
class TestInferredSpans(unittest.TestCase):
1724-
def tearDown(self):
1725-
_clean_up_span()
17261698

17271699
def test_extract_context_from_eventbridge_event(self):
17281700
event_sample_source = "eventbridge-custom"

0 commit comments

Comments
 (0)