Skip to content

Commit c87ff6b

Browse files
authored
fix the flaky test_exec_module_failure_case by enforcing the _cold_start= True (#311)
1 parent 1688b25 commit c87ff6b

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

tests/test_cold_start.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,9 @@
77

88
class TestColdStartTracingSetup(unittest.TestCase):
99
def test_initialize_cold_start_tracing(self):
10+
cold_start._cold_start = True
1011
cold_start.initialize_cold_start_tracing() # testing double wrapping
12+
cold_start._cold_start = True
1113
cold_start.initialize_cold_start_tracing()
1214
cold_start.reset_node_stacks()
1315
for module_name in ["ast", "dis", "inspect"]:
@@ -22,6 +24,7 @@ def test_initialize_cold_start_tracing(self):
2224
def test_bad_importer_find_spec_attribute_error(self):
2325
mock_importer = object() # AttributeError when accessing find_spec
2426
meta_path.append(mock_importer)
27+
cold_start._cold_start = True
2528
cold_start.initialize_cold_start_tracing() # safe to call
2629
meta_path.pop()
2730

@@ -38,12 +41,13 @@ def find_spec(*args, **kwargs):
3841

3942
mock_importer.find_spec = find_spec
4043
meta_path.append(mock_importer)
44+
cold_start._cold_start = True
4145
cold_start.initialize_cold_start_tracing()
4246
self.assertFalse(mock_loader in cold_start.already_wrapped_loaders)
4347
meta_path.pop()
4448
os.environ["DD_COLD_START_TRACING"] = "true"
4549

46-
def xtest_exec_module_failure_case(self):
50+
def test_exec_module_failure_case(self):
4751
mock_importer = MagicMock()
4852
mock_module_spec = MagicMock()
4953
mock_module_spec.name = "test_name"
@@ -60,6 +64,7 @@ def find_spec(*args, **kwargs):
6064

6165
mock_importer.find_spec = find_spec
6266
meta_path.insert(0, mock_importer)
67+
cold_start._cold_start = True
6368
cold_start.initialize_cold_start_tracing()
6469
cold_start.reset_node_stacks()
6570
try:

0 commit comments

Comments
 (0)