Skip to content

Commit 9999a37

Browse files
Merge pull request #60 from DataDog/darcy.rayner/fix-tracing-edge-case
Fix parent source as being set as Xray, when trace merging disabled
2 parents 510f1d0 + 6018352 commit 9999a37

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

datadog_lambda/tracing.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,7 @@ def set_dd_trace_py_root(trace_context, merge_xray_traces):
234234

235235

236236
def create_function_execution_span(
237-
context, function_name, is_cold_start, trace_context
237+
context, function_name, is_cold_start, trace_context, merge_xray_traces
238238
):
239239
tags = {}
240240
if context:
@@ -246,7 +246,7 @@ def create_function_execution_span(
246246
"resource_names": context.function_name,
247247
}
248248
source = trace_context["source"]
249-
if source != TraceContextSource.DDTRACE:
249+
if source == TraceContextSource.XRAY and merge_xray_traces:
250250
tags["_dd.parent_source"] = source
251251

252252
args = {

datadog_lambda/wrapper.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,11 @@ def _before(self, event, context):
122122
if dd_tracing_enabled:
123123
set_dd_trace_py_root(dd_context, self.merge_xray_traces)
124124
self.span = create_function_execution_span(
125-
context, self.function_name, is_cold_start(), dd_context
125+
context,
126+
self.function_name,
127+
is_cold_start(),
128+
dd_context,
129+
self.merge_xray_traces,
126130
)
127131
else:
128132
set_correlation_ids()

0 commit comments

Comments
 (0)