Added failing tests for NH-3459

Author: Daniel Laberge

src/NHibernate.Test/NHSpecificTest/NH3459/Fixture.cs

@@ -0,0 +1,125 @@
+using System;
+using System.Linq;
+using NHibernate.Cfg.MappingSchema;
+using NHibernate.Linq;
+using NHibernate.Mapping.ByCode;
+using NUnit.Framework;
+
+namespace NHibernate.Test.NHSpecificTest.NH3459
+{
+	[TestFixture]
+	public class Fixture : TestCaseMappingByCode
+	{
+		protected override HbmMapping GetMappings()
+		{
+			var mapper = new ModelMapper();
+			mapper.Class<Order>(rc =>
+				{
+					rc.Table("Orders");
+					rc.Id(x => x.Id, m => m.Generator(Generators.GuidComb));
+					rc.Property(x => x.Name);
+					rc.Set(x => x.OrderLines, m =>
+						{
+							m.Inverse(true);
+							m.Key(k =>
+								{
+									k.Column("OrderId");
+									k.NotNullable(true);
+								});
+							m.Cascade(Mapping.ByCode.Cascade.All.Include(Mapping.ByCode.Cascade.DeleteOrphans));
+							m.Access(Accessor.NoSetter);
+						}, m => m.OneToMany());
+				});
+			mapper.Class<OrderLine>(rc =>
+				{
+					rc.Table("OrderLines");
+					rc.Id(x => x.Id, m => m.Generator(Generators.GuidComb));
+					rc.Property(x => x.Manufacturer);
+					rc.ManyToOne(x => x.Order, m => m.Column("OrderId"));
+				});
+
+			return mapper.CompileMappingForAllExplicitlyAddedEntities();
+		}
+
+		protected override void OnSetUp()
+		{
+			using (var session = OpenSession())
+			using (var transaction = session.BeginTransaction())
+			{
+				var o1 = new Order {Name = "Order 1"};
+				session.Save(o1);
+
+				var o2 = new Order {Name = "Order 2"};
+				session.Save(o2);
+
+				session.Save(new OrderLine {Manufacturer = "AMD", Order = o2});
+
+				var o3 = new Order {Name = "Order 3"};
+				session.Save(o3);
+
+				session.Save(new OrderLine {Manufacturer = "AMD", Order = o3});
+				session.Save(new OrderLine {Manufacturer = "NVIDIA", Order = o3});
+				session.Save(new OrderLine {Manufacturer = "INTEL", Order = o3});
+
+				transaction.Commit();
+			}
+		}
+
+		protected override void OnTearDown()
+		{
+			using (var session = OpenSession())
+			using (var transaction = session.BeginTransaction())
+			{
+				session.Delete("from System.Object");
+
+				session.Flush();
+				transaction.Commit();
+			}
+		}
+
+		[Test]
+		public void LeftOuterJoinAndGroupBy()
+		{
+			using (var session = OpenSession())
+			using (session.BeginTransaction())
+			{
+				var result = (from o in session.Query<Order>()
+				              from ol in o.OrderLines.DefaultIfEmpty()
+				              group ol by ol.Manufacturer into grp
+				              select new {grp.Key}).ToList();
+
+				Assert.AreEqual(4, result.Count);
+			}
+		}
+
+		[Test]
+		public void LeftOuterJoinWithInnerRestrictionAndGroupBy()
+		{
+			using (var session = OpenSession())
+			using (session.BeginTransaction())
+			{
+				var result = (from o in session.Query<Order>()
+				              from ol in o.OrderLines.Where(x => x.Manufacturer == "AMD").DefaultIfEmpty()
+				              group o by o.Name into grp
+				              select new {grp.Key}).ToList();
+
+				Assert.AreEqual(3, result.Count);
+			}
+		}
+
+		[Test]
+		public void LeftOuterJoinWithOuterRestrictionAndGroupBy()
+		{
+			using (var session = OpenSession())
+			using (session.BeginTransaction())
+			{
+				var result = (from o in session.Query<Order>()
+							  from ol in o.OrderLines.DefaultIfEmpty().Where(x => x.Manufacturer == "AMD")
+							  group o by o.Name into grp
+							  select new { grp.Key }).ToList();
+
+				Assert.AreEqual(2, result.Count);
+			}
+		}
+	}
+}

src/NHibernate.Test/NHSpecificTest/NH3459/Order.cs

@@ -0,0 +1,24 @@
+using System;
+using System.Collections.Generic;
+
+namespace NHibernate.Test.NHSpecificTest.NH3459
+{
+	public class Order
+	{
+		private readonly IEnumerable<OrderLine> _orderLines = new List<OrderLine>();
+		public virtual Guid Id { get; set; }
+		public virtual string Name { get; set; }
+
+		public virtual IEnumerable<OrderLine> OrderLines
+		{
+			get { return _orderLines; }
+		}
+	}
+
+	public class OrderLine
+	{
+		public virtual Guid Id { get; set; }
+		public virtual string Manufacturer { get; set; }
+		public virtual Order Order { get; set; }
+	}
+}

src/NHibernate.Test/NHibernate.Test.csproj

@@ -670,6 +670,8 @@
     <Compile Include="NHSpecificTest\BagWithLazyExtraAndFilter\Domain.cs" />
     <Compile Include="NHSpecificTest\BagWithLazyExtraAndFilter\Fixture.cs" />
     <Compile Include="Component\Basic\ComponentWithUniqueConstraintTests.cs" />
+    <Compile Include="NHSpecificTest\NH3459\Fixture.cs" />
+    <Compile Include="NHSpecificTest\NH3459\Order.cs" />
     <Compile Include="NHSpecificTest\NH2692\Fixture.cs" />
     <Compile Include="NHSpecificTest\NH2692\Model.cs" />
     <Compile Include="NHSpecificTest\NH2772\Model.cs" />